ffc team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Tue, Nov 29, 2011 at 09:11:58PM +0100, Kristian Ølgaard wrote:
> On 29 November 2011 14:00, Anders Logg <logg@xxxxxxxxx> wrote:
> > On Tue, Nov 29, 2011 at 01:49:15PM +0100, Johannes Ring wrote:
> >> On Tue, Nov 29, 2011 at 1:37 PM, Anders Logg <logg@xxxxxxxxx> wrote:
> >> > On Tue, Nov 29, 2011 at 12:15:31PM +0100, Johannes Ring wrote:
> >> >> On Tue, Nov 29, 2011 at 7:15 AM, Anders Logg <logg@xxxxxxxxx> wrote:
> >> >> > The buildbot is broken after yesterday's release. The release script
> >> >> > was partly broken so I ended up redoing the release a couple of timees
> >> >> > before everything worked.
> >> >> >
> >> >> > The strange thing now is that the tests work fine locally in my
> >> >> > repository. I have committed and bzr seems to think I have nothing to
> >> >> > push. Can someone else check? In particular, do you have 1.0-rc1+ in
> >> >> > the reference header files? I do.
> >> >>
> >> >> I have 1.0-rc1 in the files in test/regression/references/r_auto, but
> >> >> in test/regression/references/r_quadrature* I have version 1.0-beta2+.
> >> >
> >> > Strange!
> >> >
> >> > Look at this:
> >> >
> >> > $ bzr pull lp:ffc
> >> > No revisions to pull.
> >> >
> >> > $ bzr push lp:ffc
> >> > No new revisions to push.
> >> >
> >> > $ bzr diff lp:ffc
> >> >
> >> > $ grep "generated by" test/regression/references/r_auto/Poisson.h
> >> > // and was automatically generated by FFC version 1.0-rc1+.
> >>
> >> Sorry, I meant I have 1.0-rc1+ in test/regression/references/r_auto:
> >>
> >>   $ grep "generated by" test/regression/references/r_auto/Poisson.h
> >>   // and was automatically generated by FFC version 1.0-rc1+.
> >>
> >> But I have 1.0-beta2+ in test/regression/references/r_quadrature*:
> >>
> >>   $ grep "generated by" test/regression/references/r_quadrature/Poisson.h
> >>   // and was automatically generated by FFC version 1.0-beta2+.
> >>   $ grep "generated by" test/regression/references/r_quadrature_O/Poisson.h
> >>   // and was automatically generated by FFC version 1.0-beta2+.
> >>
> >> Do you?
> >
> > Same here. ok, now I see what the problem is. The recent work by Marie
> > of adding regression testing for various compiler options means the
> > release script needs to be updated.
> >
> > We're now running
> >
> >  python test.py --fast
> >
> > which means not all references will be updated.
> >
> > Should we add another flag in the release script, or change --fast to
> > include all representations?
> >
> > Opinions from Marie and Kristian?
>
> I think that --fast should be changed to include all representations.
>
> The current meaning of --fast is to compare the generated header files
> to the references, but to skip program validation (g++ compilation,
> executing code and comparing output values). Now we have references
> for two more representations (not just 'auto') so the natural thing to
> do is to compare the output of those representations too. It will be a
> bit slower, but still a lot faster than running all tests.

Marie and I discussed this back and forth earlier today and landed on
letting --fast do what it does now. Marie added --generate-only to do
what you describe. This is now used by the release script.

--
Anders