← Back to team overview

ffc team mailing list archive

Re: Fwd: [Branch ~ffc-core/ffc/main] Rev 1866: Merge work of Benjamin Kehlet on including Radau and Lobatto

 

On 5 April 2013 15:31, Marie E. Rognes <meg@xxxxxxxxx> wrote:
> On 04/05/2013 04:41 AM, Garth N. Wells wrote:
>>
>> This change breaks installation of FFC:
>>
>> ffc/ext/time_elements_interface.cpp:23:10: fatal error:
>> 'numpy/arrayobject.h' file not found
>> #include <numpy/arrayobject.h>
>>
>> I assume that to commit doesn't check for the numpy path.
>
>
> Ah, thanks for pointing that out. This should be fixed now (thanks
> Johannes!)
>
>
>> It's also a lot of C++ code for FFC, which is a Python library.
>
>
>
> As far as I've understood, it is in C++ for the sake of speed. We added it
> to FFC because (a) the functionality belongs there (or in FIAT) naturally
> and (b) we did not want to introduce more projects to maintain (rather the
> opposite). This can of course be reevaluated if the move to one repository
> with multiple projects is carried out. I don't have a strong opinion on this
> (but want the functionality :-) )
>

OK. It does look like it could be done fast using numpy. It would be
nice to keep FFC unencumbered by C++ (apart from the tests). Something
for after the git transition . . .

Garth

> --
> Marie
>
>> Garth
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~ffc
> Post to     : ffc@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~ffc
> More help   : https://help.launchpad.net/ListHelp


References