← Back to team overview

fiat team mailing list archive

Re: fiat-0.9.0.tar.gz

 

On Wed, Feb 3, 2010 at 2:04 PM, Marie Rognes <meg@xxxxxxxxx> wrote:
> Anders Logg wrote:
>>
>> I will be in a meeting the next couple of hours, but I'm sure Marie,
>> Kristian or Garth can clean this up. :-) We should remove all .pyc
>> files, the duplicate files in the root directory and use
>> /usr/bin/env/python. Don't know about the license.
>>
>> --
>> Anders
>>
>>
>> On Wed, Feb 03, 2010 at 01:50:03PM +0100, Johannes Ring wrote:
>>
>>>
>>> Hi,
>>>
>>> I'm about to upload the FIAT package to Debian but I have some
>>> questions/comments regarding the fiat-0.9.0.tar.gz tarball:
>>>
>>> * In FIAT/derivs there is a LICENSE file containing the CeCILL-C
>>> license. Are the files in this folder (Derivatives.py and
>>> FirstDerivatives.py) released under this license? Who has the
>>> copyright for those files? Konrad Hinsen seems to be the author.
>>>
>>>
>
> Is the stuff in derivs used anywhere?

It doesn't seem like it:

johannr@simula-x61:fiat$ grep Derivatives FIAT/*.py
FIAT/expansions.py:    import Scientific.Functions.Derivatives as Derivatives
FIAT/expansions.py:    import Scientific.Functions.FirstDerivatives as
FirstDerivatives
FIAT/expansions.py:        from Derivatives import DerivVar
FIAT/expansions.py:        from Derivatives import DerivVar
FIAT/expansions.py:    from FirstDerivatives import DerivVar
FIAT/functional.py:import Scientific.Functions.Derivatives as Derivatives
FIAT/functional.py:import Scientific.Functions.FirstDerivatives as
FirstDerivatives
FIAT/functional.py:            dpt = tuple( [ Derivatives.DerivVar(
pt[i] , i , self.max_deriv_order ) \
FIAT/functional.py:                dpt.append( Derivatives.DerivVar(
pt[i] , i , dorder ) )
FIAT/functional.py:        dx = tuple( [ Derivatives.DerivVar( x[i] ,
i , self.order ) \
FIAT/functional.py:        dx = tuple( [ FirstDerivatives.DerivVar( x[i] , i ) \
FIAT/newdubiner.py:    from Scientific.Functions.Derivatives import
DerivVar as DV
FIAT/newdubiner.py:    from Scientific.Functions.Derivatives import
DerivVar as DV
FIAT/polynomial_set.py:import Scientific.Functions.FirstDerivatives as
FirstDerivatives
FIAT/polynomial_set.py:            dpts = numpy.array( [ tuple(
[FirstDerivatives.DerivVar( x[i] , i ) \
johannr@simula-x61:fiat$

Maybe they were used before Scientific Python was made a dependency?

Johannes

> --
> Marie
>
>
>>> * The Python interpreter in FIAT/ascii2vtk*.py is #!/sw/bin/python and
>>> I get (lintian) errors on the generated packages:
>>>
>>>    E: python-fiat: wrong-path-for-interpreter
>>> ./usr/share/pyshared/FIAT/asci2vtk2d.py (#!/sw/bin/python !=
>>> /usr/bin/python)
>>>    E: python-fiat: wrong-path-for-interpreter
>>> ./usr/share/pyshared/FIAT/asci2vtk3d.py (#!/sw/bin/python !=
>>> /usr/bin/python)
>>>
>>> I have patched these files to use #!/usr/bin/env python instead to get
>>> around this issue.
>>>
>>> * There are .pyc files in FIAT/derivs. They are also in the bazaar
>>> repository. It would be good to remove them.
>>>
>>> * Version in setup.py is 3.3.0.
>>>
>>> * There are some .py files in the root folder and some of them are
>>> duplicates of files in the FIAT subfolder (ascii2vtk*.py, tablag.py).
>>>
>>> Johannes
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~fiat
>>> Post to     : fiat@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~fiat
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>  ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~fiat
>>> Post to     : fiat@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~fiat
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>
>



Follow ups

References