freyja-dev team mailing list archive

[Chris Glass <christopher.glass@xxxxxxxxxxxxx>]

Chris Glass has proposed merging lp:~tribaal/unity-tweak-tool/fix-show-desktop-core-dump into lp:unity-tweak-tool.

Commit message:
Only activate the "Show desktop" option of the "Window spread" section if the option is available.

Requested reviews:
  Freyja Development (freyja-dev)
Related bugs:
  Bug #1281467 in Unity Tweak Tool: "GLib-GIO-ERROR **: Settings schema 'org.compiz.scale' does not contain a key named 'show-desktop' "
  https://bugs.launchpad.net/unity-tweak-tool/+bug/1281467

For more details, see:
https://code.launchpad.net/~tribaal/unity-tweak-tool/fix-show-desktop-core-dump/+merge/207381

This fixes the linked bug by only activating the "Show desktop" option of the "Window spread" section (labeled as "Click to access desktop") if the option is actually available.

Pretty straightforward check. While this was not tested on previous ubuntu versions it should work fine on saucy (since the key will be defined there).
-- 
https://code.launchpad.net/~tribaal/unity-tweak-tool/fix-show-desktop-core-dump/+merge/207381
Your team Freyja Development is requested to review the proposed merge of lp:~tribaal/unity-tweak-tool/fix-show-desktop-core-dump into lp:unity-tweak-tool.

=== modified file 'UnityTweakTool/section/spaghetti/compiz.py'
--- UnityTweakTool/section/spaghetti/compiz.py	2013-05-13 02:55:19 +0000
+++ UnityTweakTool/section/spaghetti/compiz.py	2014-02-20 09:57:22 +0000
@@ -428,7 +428,8 @@
         else:
             self.ui['check_overlay_emblem'].set_active(False)
 
-        self.ui['check_click_desktop'].set_active(gsettings.scale.get_boolean('show-desktop'))
+        if 'show-desktop' in gsettings.scale.list_keys():
+            self.ui['check_click_desktop'].set_active(gsettings.scale.get_boolean('show-desktop'))
 
         model = self.ui['list_compiz_windows_spread_accelerators']