fuel-dev team mailing list archive

[Dmitry Pyzhov <dpyzhov@xxxxxxxxxxxx>]

Exactly. Do not change Change-ID. It is our last resort. Without it we have
no reliable method to check in which branches we merged a patchset.


On Thu, Apr 3, 2014 at 12:49 PM, Evgeniy L <eli@xxxxxxxxxxxx> wrote:

> Hi Dmitry,
>
> This patches are same but they have different Change-Id:
>
> https://review.openstack.org/#/c/84203/
> https://review.openstack.org/#/c/80689/
>
> I thought we agreed not to change Change-Id when we backport patches, am
> I right?
>
> Thanks
>
>
>
> On Thu, Apr 3, 2014 at 2:27 AM, Dmitry Borodaenko <
> dborodaenko@xxxxxxxxxxxx> wrote:
>
>> FAO core reviewers:
>>
>> https://review.openstack.org/84544 (Subs 1.0.0.0 -> 198.18.1.[1|2] in
>> network checker) -- backport of a fix by Vladimir Kozhukalov, needs to
>> be reviewed (wasn't a trivial rebase) and merged into fuel-main
>> stable/4.1
>>
>> https://review.openstack.org/84203 (do not create radosgw region map
>> in post-deploy) -- backport of my fix for fuel-astute stable/4.1, also
>> not a trivial rebase, but a very obvious change so should not be a
>> problem
>>
>> https://review.openstack.org/82965 (Set Ceph pg_num dynamically based
>> on fuel_settings) -- proposed for fuel-library master, will need a
>> backport once merged, fuel-web counterpart is already merged in master
>> and stable/4.1
>>
>> https://review.openstack.org/82629 (Use internal IP for internal and
>> admin RGW endpoints) -- proposed for fuel-library master, will need a
>> backport once merged, no external dependencies
>>
>> I'd rather not establish a bad precedent of summarily merging my own
>> commits, but these fixes are harmless enough and should really land in
>> stable/4.1 by the end of this week.
>>
>> Thanks,
>>
>> --
>> Dmitry Borodaenko
>>
>> --
>> Mailing list: https://launchpad.net/~fuel-dev
>> Post to     : fuel-dev@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~fuel-dev
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> --
> Mailing list: https://launchpad.net/~fuel-dev
> Post to     : fuel-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~fuel-dev
> More help   : https://help.launchpad.net/ListHelp
>
>