← Back to team overview

fuel-dev team mailing list archive

Re: Login and Logout actions are absent in Nailgun

 

Hi all,

I started implement login/logout handlers for Nailgun. I'd be grateful
if python team make review of my patchset [1], since I may do
something wrong.

So feedback is very welcome!

[1]: https://review.openstack.org/#/c/123444/

- Igor

On Mon, Sep 22, 2014 at 4:47 PM, Alexander Kislitsky
<akislitsky@xxxxxxxxxxxx> wrote:
> Definitely, login and logout API calls must be in Nailgun API.
> For now we can implement collecting of anonymous statistics without info
> about login/logout and begin to consider them after login/logout will be
> implemented in the Nailgun API.
>
> On Mon, Sep 22, 2014 at 4:59 PM, Igor Kalnitsky <ikalnitsky@xxxxxxxxxxxx>
> wrote:
>>
>> Hi folks,
>>
>> Today I took a look over "logout issue" [1] and figured out that we
>> cannot implement it with current approach.
>>
>> In current approach both login and logout actions are handled by Web
>> UI with direct requests to Keystone server [2].
>>
>> As far as I know, we want to track login/logout actions as a part of
>> anonymous statistic [3], so we need to decide how to avoid this issue
>> and make it fly.
>>
>> I think we need to implement login/logout handlers as a part of
>> Nailgun API. A login handler should receive user credentials and make
>> request to Keystone server in order to retrieve an auth token. A
>> logout handler should mark the token as invalid and forbid any actions
>> with this token.
>>
>> Fuel Web UI should work with login/logout handlers which are part of
>> Nailgun, instead of working with Keystone directly.
>>
>> What do you think about it? Any ideas and suggestions are welcome!
>>
>>
>> [1]: https://bugs.launchpad.net/fuel/+bug/1370964
>> [2]:
>> https://github.com/stackforge/fuel-web/blob/master/nailgun/static/js/app.js#L70
>> [3]: https://blueprints.launchpad.net/fuel/+spec/send-anon-usage
>>
>>
>> - Igor
>
>


References