← Back to team overview

fuel-dev team mailing list archive

Re: Custom ISOs with pull instead of cherry-pick

 

On Wed, Oct 22, 2014 at 7:20 PM, Aleksandr Didenko <adidenko@xxxxxxxxxxxx>
wrote:

> fuellib_gerrit_commit = refs/changes/68/127268/7 refs/changes/89/127589/6
> refs/changes/07/86007/14 refs/changes/08/86008/18
>
> If we change "cherry-pick" to "pull" (
> https://review.openstack.org/#/c/130233/2/repos.mk) then you don't have
> to list dependencies for your gerrit commits, since pull will fetch them
> for you:
>
> fuellib_gerrit_commit = refs/changes/89/127589/6 refs/changes/08/86008/18


I propose make following logic:

fuellib_gerrit_commit = @refs/changes/89/127589/6 refs/changes/08/86008/18

If ref-ID begins '@' gerrit should pull this changeset with all dependensies
if no -- we just cherry-pick changeset, no more.

This give us some flexebility and save backward compatibility.


/sv

Follow ups

References