← Back to team overview

geda-developers team mailing list archive

Re: Cycle drag segfaults

 

gedau@xxxxxxxxxxxxx wrote:
Hi Bert,

boundled with cycledrag comes a feature that's common in CAD systems I used before PCB: direction of selection drag&drop changes how selection works. "Positive" selection (left->right, top->down) means "select objects that are fully within the box", whereas "negative" selection is "select anything that has any portion overlapping with the box".

While I was at the geometry fixes for cycdrag, I fixed a seemingly unrelated bug that kept points detected within negative boxes, rendering some of the selections defunct. When applying the cycdrag patches, please grab r977 as well!

Regards,

Igor2


Hi Igor2,

I have applied the diffs r975 and r976 to the "home/bert/cycdrag" branch in vanilla pcb.

Now I have to start testing ;-)

For diff r977 (implementing the "envelope" versus "intersect" selection behaviour) I get the impression that this one is not related to cycle-drag selection.

If added it may cause a breach of the principle of "least surprise" if not fully grasped by the testers/reviewers.

I'd better put this one in a separate topic branch to be reviewed on its own merits.

More testing to do.

Thanks for the diffs and kind regards,

Bert Timmerman.