← Back to team overview

gma500 team mailing list archive

[Bug 1000545] Re: Update to 3.5.2

 

So, code like that:
  gtk_theming_engine_get (engine, state,
                          /* Can't use border-radius as it's an int for
                           * backwards compat */
                          "border-top-left-radius", &top_left_radius,
                          "border-top-right-radius", &top_right_radius,
                          "border-bottom-right-radius", &bottom_right_radius,
                          "border-bottom-left-radius", &bottom_left_radius,
                          NULL);

is making the engine crash.
what we need to do is replace this with an alternative. Now gtk uses GtkCssValue, we might want to switch over this.

The main unico files that need to be updated is gtkroundedbox.c and
gtkroundedboxprivate.h, which were taken from gtk. We need to upgrade
following this commit
http://git.gnome.org/browse/gtk+/commit/gtk/gtkroundedbox.c?id=edbc8e4f57b871ee151443fe867f6e347682fe8d
and switch to the new struts, copying what needed.

Another file that was using those calls is unico-draw.c, while rendering
the frame_gap. Again, check gtk to see how it changed.

I know it's ugly, but likely in ubuntu 13.04 we could use CSS for our
themes, currently Ambiance requires some extensions thus unico

-- 
You received this bug notification because you are a member of GMA500
Team, which is subscribed to Unico.
https://bugs.launchpad.net/bugs/1000545

Title:
  Update to 3.5.2

Status in The Unico Gtk+ Theming Engine:
  Confirmed
Status in “gtk+3.0” package in Ubuntu:
  In Progress
Status in “light-themes” package in Ubuntu:
  Confirmed

Bug description:
  Branch ready in lp:~ubuntu-desktop/gtk/ubuntugtk3 but light-themes
  doesn't work well with it

To manage notifications about this bug go to:
https://bugs.launchpad.net/unico/+bug/1000545/+subscriptions