gnome-split-team team mailing list archive
-
gnome-split-team team
-
Mailing list archive
-
Message #00137
[Branch ~respawneral/gnome-split/mainline] Rev 258: Fix common mistakes.
------------------------------------------------------------
revno: 258
committer: Guillaume Mazoyer <respawneral@xxxxxxxxx>
branch nick: wrong-code-removal
timestamp: Tue 2011-06-28 14:37:26 +0200
message:
Fix common mistakes.
modified:
src/org/gnome/split/GnomeSplit.java
src/org/gnome/split/core/merger/Generic.java
src/org/gnome/split/core/merger/GnomeSplit.java
src/org/gnome/split/core/merger/KFK.java
src/org/gnome/split/core/merger/Xtremsplit.java
src/org/gnome/split/core/merger/YoyoCut.java
src/org/gnome/split/core/splitter/Generic.java
src/org/gnome/split/core/splitter/GnomeSplit.java
src/org/gnome/split/core/splitter/KFK.java
src/org/gnome/split/core/splitter/Xtremsplit.java
src/org/gnome/split/core/splitter/YoyoCut.java
src/org/gnome/split/core/utils/MD5Hasher.java
src/org/gnome/split/gtk/widget/SplitWidget.java
src/org/gnome/split/gtk/widget/assistant/ActionAssistant.java
src/org/gnome/split/gtk/widget/base/UnitsBox.java
--
lp:gnome-split
https://code.launchpad.net/~respawneral/gnome-split/mainline
Your team GNOME Split developers is subscribed to branch lp:gnome-split.
To unsubscribe from this branch go to https://code.launchpad.net/~respawneral/gnome-split/mainline/+edit-subscription
=== modified file 'src/org/gnome/split/GnomeSplit.java'
--- src/org/gnome/split/GnomeSplit.java 2011-01-04 12:56:24 +0000
+++ src/org/gnome/split/GnomeSplit.java 2011-06-28 12:37:26 +0000
@@ -288,7 +288,8 @@
try {
Gtk.showURI(new URI(uri));
} catch (URISyntaxException e) {
- // Can be dropped, should *never* happen
+ // Should *never* happen
+ e.printStackTrace();
}
}
=== modified file 'src/org/gnome/split/core/merger/Generic.java'
--- src/org/gnome/split/core/merger/Generic.java 2011-01-04 12:56:24 +0000
+++ src/org/gnome/split/core/merger/Generic.java 2011-06-28 12:37:26 +0000
@@ -152,7 +152,7 @@
// Close the final file
out.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
=== modified file 'src/org/gnome/split/core/merger/GnomeSplit.java'
--- src/org/gnome/split/core/merger/GnomeSplit.java 2011-01-04 12:56:24 +0000
+++ src/org/gnome/split/core/merger/GnomeSplit.java 2011-06-28 12:37:26 +0000
@@ -74,7 +74,7 @@
try {
access.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
@@ -195,7 +195,7 @@
// Close the final file
out.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
=== modified file 'src/org/gnome/split/core/merger/KFK.java'
--- src/org/gnome/split/core/merger/KFK.java 2011-01-04 12:56:24 +0000
+++ src/org/gnome/split/core/merger/KFK.java 2011-06-28 12:37:26 +0000
@@ -125,7 +125,7 @@
// Close the final file
out.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
=== modified file 'src/org/gnome/split/core/merger/Xtremsplit.java'
--- src/org/gnome/split/core/merger/Xtremsplit.java 2011-01-04 12:56:24 +0000
+++ src/org/gnome/split/core/merger/Xtremsplit.java 2011-06-28 12:37:26 +0000
@@ -116,7 +116,7 @@
try {
access.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
@@ -261,7 +261,7 @@
// Close the final file
out.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
=== modified file 'src/org/gnome/split/core/merger/YoyoCut.java'
--- src/org/gnome/split/core/merger/YoyoCut.java 2011-01-04 12:56:24 +0000
+++ src/org/gnome/split/core/merger/YoyoCut.java 2011-06-28 12:37:26 +0000
@@ -123,7 +123,7 @@
try {
access.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
@@ -233,7 +233,7 @@
// Close the final file
out.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
=== modified file 'src/org/gnome/split/core/splitter/Generic.java'
--- src/org/gnome/split/core/splitter/Generic.java 2011-01-04 12:56:24 +0000
+++ src/org/gnome/split/core/splitter/Generic.java 2011-06-28 12:37:26 +0000
@@ -97,7 +97,7 @@
// Close the part file
access.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
@@ -109,7 +109,7 @@
// Close the part file
toSplit.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
=== modified file 'src/org/gnome/split/core/splitter/GnomeSplit.java'
--- src/org/gnome/split/core/splitter/GnomeSplit.java 2011-01-04 12:56:24 +0000
+++ src/org/gnome/split/core/splitter/GnomeSplit.java 2011-06-28 12:37:26 +0000
@@ -154,7 +154,7 @@
// Close the part file
access.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
@@ -166,7 +166,7 @@
// Close the part file
toSplit.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
=== modified file 'src/org/gnome/split/core/splitter/KFK.java'
--- src/org/gnome/split/core/splitter/KFK.java 2011-01-04 12:56:24 +0000
+++ src/org/gnome/split/core/splitter/KFK.java 2011-06-28 12:37:26 +0000
@@ -85,7 +85,7 @@
// Close the part file
access.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
@@ -97,7 +97,7 @@
// Close the part file
toSplit.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
=== modified file 'src/org/gnome/split/core/splitter/Xtremsplit.java'
--- src/org/gnome/split/core/splitter/Xtremsplit.java 2011-01-04 12:56:24 +0000
+++ src/org/gnome/split/core/splitter/Xtremsplit.java 2011-06-28 12:37:26 +0000
@@ -179,7 +179,7 @@
// Close the part file
access.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
@@ -191,7 +191,7 @@
// Close the part file
toSplit.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
=== modified file 'src/org/gnome/split/core/splitter/YoyoCut.java'
--- src/org/gnome/split/core/splitter/YoyoCut.java 2011-01-04 12:56:24 +0000
+++ src/org/gnome/split/core/splitter/YoyoCut.java 2011-06-28 12:37:26 +0000
@@ -142,7 +142,7 @@
// Close the part file
access.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
@@ -154,7 +154,7 @@
// Close the part file
toSplit.close();
} catch (IOException e) {
- // Drop the exception
+ e.printStackTrace();
}
}
}
=== modified file 'src/org/gnome/split/core/utils/MD5Hasher.java'
--- src/org/gnome/split/core/utils/MD5Hasher.java 2011-01-04 12:56:24 +0000
+++ src/org/gnome/split/core/utils/MD5Hasher.java 2011-06-28 12:37:26 +0000
@@ -46,7 +46,7 @@
try {
algorithm = MessageDigest.getInstance("MD5");
} catch (NoSuchAlgorithmException e) {
- // Should not happened
+ e.printStackTrace();
}
}
=== modified file 'src/org/gnome/split/gtk/widget/SplitWidget.java'
--- src/org/gnome/split/gtk/widget/SplitWidget.java 2011-05-08 10:14:50 +0000
+++ src/org/gnome/split/gtk/widget/SplitWidget.java 2011-06-28 12:37:26 +0000
@@ -149,7 +149,7 @@
sizeButton = new SpinButton(1, 4096, 1);
splitSize.packStart(sizeButton, true, true, 0);
- sizeUnits = new UnitsBox(app);
+ sizeUnits = new UnitsBox();
splitSize.packStart(sizeUnits, true, true, 0);
// Pack algorithm related widgets
=== modified file 'src/org/gnome/split/gtk/widget/assistant/ActionAssistant.java'
--- src/org/gnome/split/gtk/widget/assistant/ActionAssistant.java 2011-02-19 16:17:00 +0000
+++ src/org/gnome/split/gtk/widget/assistant/ActionAssistant.java 2011-06-28 12:37:26 +0000
@@ -375,7 +375,7 @@
box.packStart(button, true, true, 0);
// Create the list of units
- final UnitsBox units = new UnitsBox(app);
+ final UnitsBox units = new UnitsBox();
box.packStart(units, true, true, 0);
// Add a last label to see if the size is valid
=== modified file 'src/org/gnome/split/gtk/widget/base/UnitsBox.java'
--- src/org/gnome/split/gtk/widget/base/UnitsBox.java 2011-05-05 20:23:30 +0000
+++ src/org/gnome/split/gtk/widget/base/UnitsBox.java 2011-06-28 12:37:26 +0000
@@ -21,7 +21,6 @@
package org.gnome.split.gtk.widget.base;
import org.gnome.gtk.ComboBoxText;
-import org.gnome.split.GnomeSplit;
import org.gnome.split.core.utils.SizeUnit;
/**
@@ -31,7 +30,7 @@
*/
public class UnitsBox extends ComboBoxText
{
- public UnitsBox(final GnomeSplit app) {
+ public UnitsBox() {
super();
// Add all units
