← Back to team overview

gnome-split-team team mailing list archive

[Branch ~respawneral/gnome-split/mainline] Rev 265: Fix last assistant step not starting the action.

 

------------------------------------------------------------
revno: 265
fixes bug(s): https://launchpad.net/bugs/824190
committer: Guillaume Mazoyer <respawneral@xxxxxxxxx>
branch nick: assistant-fix
timestamp: Sat 2011-09-03 13:00:39 +0200
message:
  Fix last assistant step not starting the action.
  
  Wait for the interface to be fully updated before
  starting the action. The action being processed
  by a thread sometimes interrupt the main loop of
  GTK and did not wait for the interface to be
  fully updated. This problem was the origin of the
  error message telling that all the fields were
  not filled.
modified:
  src/org/gnome/split/gtk/widget/assistant/ActionAssistant.java


--
lp:gnome-split
https://code.launchpad.net/~respawneral/gnome-split/mainline

Your team GNOME Split developers is subscribed to branch lp:gnome-split.
To unsubscribe from this branch go to https://code.launchpad.net/~respawneral/gnome-split/mainline/+edit-subscription
=== modified file 'src/org/gnome/split/gtk/widget/assistant/ActionAssistant.java'
--- src/org/gnome/split/gtk/widget/assistant/ActionAssistant.java	2011-08-14 21:40:20 +0000
+++ src/org/gnome/split/gtk/widget/assistant/ActionAssistant.java	2011-09-03 11:00:39 +0000
@@ -31,6 +31,7 @@
 import org.gnome.gtk.FileChooserAction;
 import org.gnome.gtk.FileChooserButton;
 import org.gnome.gtk.FileFilter;
+import org.gnome.gtk.Gtk;
 import org.gnome.gtk.HBox;
 import org.gnome.gtk.IconSize;
 import org.gnome.gtk.Image;
@@ -541,6 +542,11 @@
             // Update the widget
             this.updateWidget();
 
+            // Wait for the interface to be fully updated
+            while (Gtk.eventsPending()) {
+                Gtk.mainIterationDo(false);
+            }
+
             // Start the split/merge if requested
             app.getActionManager().activateAction(ActionId.START);