← Back to team overview

gnusim8085-devel team mailing list archive

Re: [gnusim8085-commits] SF.net GIT: gnusim8085 branch, master, updated. 6da3583384f0ef010104aacb3c36426fe2e18bb2

 

On Tue, Dec 29, 2009 at 10:42 AM, Sridhar Ratnakumar
<nearfar@xxxxxxxxxxxxxxxxxxxxx> wrote:
<snip>
> - Log -----------------------------------------------------------------
> commit 6da3583384f0ef010104aacb3c36426fe2e18bb2
> Author: srid <sridhar.ratna@xxxxxxxxx>
> Date:   Mon Dec 28 21:12:29 2009 -0800
>
>    Fix GtkSourceView deprecation wdarning
>
> diff --git a/ChangeLog b/ChangeLog
> index 6fb279d..5cf7173 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +2009-12-28  Sridhar Ratnakumar <srid@xxxxxxxxxxx>
> +
> +       * src/gui-editor.c: Fix deprecation warning from GtkSourceView
> +
>  2009-12-28  Onkar Shinde  <onkarshinde@xxxxxxxxx>
>
>        * configure.in: Gettext version updated to 0.17. Removed a bunch of
> diff --git a/src/gui-editor.c b/src/gui-editor.c
> index 6a24c4d..b5498e8 100644
> --- a/src/gui-editor.c
> +++ b/src/gui-editor.c
> @@ -77,7 +77,7 @@ gui_editor_new (void)
>   pixbuf = gui_editor_get_stock_icon (GTK_WIDGET(self->widget), GTK_STOCK_NO, GTK_ICON_SIZE_MENU);
>   if (pixbuf)
>        {
> -         gtk_source_view_set_mark_category_pixbuf (GTK_SOURCE_VIEW (self->widget), MARKER_BREAKPOINT, pixbuf);
> +         gtk_source_view_set_mark_category_icon_from_pixbuf (GTK_SOURCE_VIEW (self->widget), MARKER_BREAKPOINT, pixbuf);
>          g_object_unref (pixbuf);
>        }
>


This change is wrong. This single change bumps the required version of
gtksourceview to 2.8 and puts all the stable version of Ubuntu except
karmic out of supported list. :-(
I am trying hard to keep the required versions of GTK+ and
gtksourceview at 2.12 and 2.2 respectively.

Please revert the change.


Onkar



Follow ups