← Back to team overview

group.of.nepali.translators team mailing list archive

[Bug 1584231] Re: update to 0.43 (aka, support 'confinement' field in snap v2 yaml)

 

This was fixed in yakkety in 0.43.

** Changed in: click-reviewers-tools (Ubuntu Yakkety)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1584231

Title:
  update to 0.43 (aka, support 'confinement' field in snap v2 yaml)

Status in click-reviewers-tools package in Ubuntu:
  Fix Released
Status in click-reviewers-tools source package in Xenial:
  In Progress
Status in click-reviewers-tools source package in Yakkety:
  Fix Released

Bug description:
  [Impact]
  Upgrade to review tools 0.43. The review tools provide lint-style checks for clicks and snaps. This release has several bug fixes and support for new snappy yaml declarations, the most important of which is supporting the 'confinement' property.

  Here is the complete changelog:

    * sr_lint.py:
      - kernel snaps may have external symlinks
      - handle top-level plugs and slots with yaml data as 'null' (LP: #1579201)
      - add epoch checks (LP: #1583298)
      - .pyc are arch-independent, so don't complain about them
      - add confinement checks (LP: #1580819)
    * data/apparmor-easyprof-ubuntu.json:
      - add opengl interface as 'common' (LP: #1572140)
      - add reserved bluez, network-manager and location-observe interfaces
    * sr_security.py:
      - remove last reference to 'cap'
      - turn resquash test into info for now until the squashfs-tools bugs are
        fixed and this is a reliable check
    * when 'confinement' is 'devmode', override the result type to 'info'
      - common.py: add override_result_type to allow in support of 'confinement'
        overrides
      - sr_common.py: add _devmode_override()
      - sr_security.py: use override_result_type if in devmode
      - LP: #1584231

  [Test Case]
  The testsuite tests the above and the store is already using these checks. To verify the package:
  1. install the package
  2. verify click reviews work with: click-review /path/to/click
  3. verify snapv1 reviews work with: click-review /path/to/15.04/snap
  4. verify snapv2 reviews work with: click-review /path/to/16/snap

  [Regression Potential]

  The worst regression is that the lint tool would trace back to the
  user running it instead of displaying the information. The testsuite
  is run during the build and is comprehensive with the added code
  maintaining 100% coverage for sr_security.py and sr_lint.py.
  sr_common.py maintaining 98% coverage.

  [Other Info]
  The store has been running r651 for weeks with no issues. r652 and later are to support the new snappy 'confinement' and 'epoch' fields as per the spec and fixes a few minor issues. The store will land this next week and if there are regressions there, I will update this bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/click-reviewers-tools/+bug/1584231/+subscriptions