group.of.nepali.translators team mailing list archive

[Launchpad Bug Tracker <1599191@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package powerpc-utils - 1.3.1-2ubuntu0.1

---------------
powerpc-utils (1.3.1-2ubuntu0.1) xenial; urgency=medium

  * debian/patches/bashisms.patch: Fix bashism in update_flash_nv.
    Closes LP: #1599191.

 -- Steve Langasek <steve.langasek@xxxxxxxxxx>  Tue, 05 Jul 2016
15:52:05 -0700

** Changed in: powerpc-utils (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1599191

Title:
  [LTCTest][Opal][OP820] update_flash -d option is throwing
  /usr/sbin/update_flash_nv: 595: [: x47: unexpected operator

Status in powerpc-utils package in Ubuntu:
  Fix Released
Status in powerpc-utils source package in Xenial:
  Fix Released

Bug description:
  [SRU Justification]
  On an OpenPower system, '/usr/sbin/update_flash_nv -d' will print a gratuitous error message, and will not correctly report failures to query the firmware version.

  [Test case]
  1. On an OpenPower system (as determined by the presence of the file /proc/device-tree/bmc), run 'sudo update_flash_nv -d'.  Observe that an error message is printed before the version information.
  2. Install powerpc-utils from xenial-proposed.
  3. Run 'sudo update_flash_nv -d' again.  Verify that no error message is printed.

  [Regression potential]
  Minimal.  This is a targeted, one-line fix for a bashism in a shell script.

  ---Problem Description---
  update_flash -d option is throwing [: x47: unexpected operator message

  ---uname output---
  Linux ltc-garri2 4.4.0-30-generic #49-Ubuntu SMP Fri Jul 1 10:00:36 UTC 2016 ppc64le ppc64le ppc64le GNU/Linux

  Machine Type = P8

  ---Steps to Reproduce---
   Install a P8 8335-GTB Hardware with Ubuntu 16.04.1 OS.
  Then execute the below command to check the version of the firmware installed on the machine.

  root@ltc-garri2:~# update_flash -d

  /usr/sbin/update_flash_nv: 595: [: x47: unexpected operator
  Firmware version:
   Product Name          : OpenPOWER Firmware
   Product Version       : IBM-garrison-ibm-OP8_v1.9_2.1
   Product Extra         :        op-build-dcacfac
   Product Extra         :        buildroot-bc248fa
   Product Extra         :        skiboot-5f25590
   Product Extra         :        hostboot-4c63029-6034fa6
   Product Extra         :        linux-4.4.9-openpower2-ebc7b6d
   Product Extra         :        petitboot-v1.1.1-fc477ec
   Product Extra         :        garrison-xml-b453a81
   Product Extra         :        occ-19a3ebc
   Product Extra         :        hostboot-binar
  root@ltc-garri2:~# echo $?
  0

  root@ltc-garri2:~# which update_flash
  /usr/sbin/update_flash

  root@ltc-garri2:~# dpkg -S /usr/sbin/update_flash
  powerpc-ibm-utils: /usr/sbin/update_flash
  root@ltc-garri2:~# dpkg --list | grep powerpc-ibm-utils
  ii  powerpc-ibm-utils                  1.3.1-2                         ppc64el      utilities for maintenance of IBM PowerPC platforms

  Userspace tool common name: /usr/sbin/update_flash

  The userspace tool has the following bit modes: 64-bit

  Userspace package: powerpc-ibm-utils

  Below upstream patch fixes this issue:

  commit c3269d4e3d4882fd931d1df6aece0bec86fb6734
  Author: Vasant Hegde <hegdevasant@xxxxxxxxxxxxxxxxxx>
  Date:   Thu Jun 30 10:26:58 2016 -0400

      update_flash: Fix bashism issue in
  opp_display_current_fw_version()

      Ubuntu uses dash, not bash. We hit below warning on Ubuntu system.

      root@abc:/sys/firmware/devicetree/base/ibm,opal/sensors# update_flash -d
      /usr/sbin/update_flash_nv: 595: [: x43: unexpected operator
      Firmware version:
      ....
      ....

      == is a bashism. Replace it with =.

      Fixes: 767e3dd7 (update_flash: Add support for OpenPower system)
      Signed-off-by: Vasant Hegde <hegdevasant@xxxxxxxxxxxxxxxxxx>

  -Vasant

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/powerpc-utils/+bug/1599191/+subscriptions