group.of.nepali.translators team mailing list archive

["Brandon B. Jozsa" <bjozsa@xxxxxxxxxx>]

** Changed in: maas/2.0
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1604128

Title:
  [2.0RC2] Unable to add a public SSH Key due to lp1604147

Status in MAAS:
  Fix Committed
Status in MAAS 2.0 series:
  Fix Released
Status in MAAS trunk series:
  Fix Committed
Status in maas package in Ubuntu:
  Fix Released
Status in maas source package in Xenial:
  Confirmed
Status in maas source package in Yakkety:
  Fix Released

Bug description:
  [Impact]
  With a recent update of python from 3.5.1 to 3.5.2, the pathlib.Path.path property is gone. This impacts MAAS as it will cause it to fail importing SSH keys, which prevents users from deploying.

  [Test Case]
  1. Install MAAS
  2. Import SSH Key (example, maas maas sshkeys create key="$(ssh-add -L | grep lee.trager@xxxxxxxxxxxxx)")

  With fix - The key will be imported correctly.
  Without fix - The key will fail to import.

  Work around sudden loss of pathlib.Path.path property in Python 3.5.2
  release.

  [Regression Potential]
  None. Tested and proved that using the different path fixes the issue.

  == Original bug report ==
  When I add a public SSH key over the API or in the UI I get the following error

  $ maas maas sshkeys create key="$(ssh-add -L | grep lee.trager@xxxxxxxxxxxxx)"
  {"key": ["Invalid SSH public key: 'PosixPath' object has no attribute 'path'"]}

  This was introduced in 5118 in the validation code of SSH keys but
  appears to be exposing a bigger bug. If you run ./bin/test.rack
  src/provisioningserver/utils/tests/test_sshkey.py the tests fail. I'm
  guessing that something is mocking check_output in a previous test and
  not unmocking it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/maas/+bug/1604128/+subscriptions