group.of.nepali.translators team mailing list archive

[Launchpad Bug Tracker <1608943@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package click-reviewers-tools - 0.44~16.04.1

---------------
click-reviewers-tools (0.44~16.04.1) xenial-proposed; urgency=medium

  [ Jamie Strandboge ]
  * data/apparmor-easyprof-ubuntu.json:
    - add pulseaudio interface
    - add bluetooth policy group for Touch for 15.04 and higher
    - add location-observe and location-control
    - move all core interfaces to 'common'
    - add gsettings interface
    - set home to auto-approve
    - add mpris interface
    - add camera interface
    - add optical-drive interface
    - add serial-port interface
    - add content interface
  * clickreviews/common.py:
    - don't fail on libmvec.so since it comes from libc6 too (LP: #1584346)
    - extend the regex to also match ld-linux-x86-64.so.2
  * sr_common.py:
    - update _verify_pkgname() and _verify_appname() to use the same regex as
      in snapd and various tests
    - update attributes to be slots or plugs side and cleanup code for
      specifying attributes
  * bin/click-review, clickreviews/modules.py: exit '1' if error with
    init_object or running checks
  * sr_lint.py:
    - support 'environment' key in yaml (LP: #1583259)
    - support 'confinement' key in yaml
  * sr_security.py:
    - specifying mpris slot should not warn
    - adjust profile name length checks to use series 16 security label format
  * run_tests: exit non-zero with failures, errors or unexpectedSuccesses
  * cr_lint.py:
    - 'puritine' is a known, but redflagged hook
    - skip external symlinks and md5sums checks for puritine (since we expect
      external symlinks and the hash checks fail on broken symlinks)
    - 'puritine' hook should not be used with 'apparmor'
  * clickreviews/apparmor_policy.py: adjust for rename of store team
    (LP: #1608943)

  [ Celso Providelo ]
  * support for interface abbreviated syntax (LP: #1595184)

 -- Jamie Strandboge <jamie@xxxxxxxxxx>  Tue, 02 Aug 2016 08:43:31 -0500

** Changed in: click-reviewers-tools (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1608943

Title:
  rename of click-reviewers LP group broke fetch of apparmor json

Status in Canonical Click Reviewers tools:
  Fix Released
Status in click-reviewers-tools package in Ubuntu:
  Fix Released
Status in click-reviewers-tools source package in Xenial:
  Fix Released
Status in click-reviewers-tools source package in Yakkety:
  Fix Released

Bug description:
  [Impact]
  Users running click-review for the first time will encounter a traceback and existing users will not fetch new versions of the apparmor json.

  [Test Case]
  $ rm -f ~/.cache/click-reviewers-tools/apparmor-easyprof-ubuntu.json
  $ click-review ./rottentomatoes.jdstrand_0.11.3_all.click 
  ./rottentomatoes.jdstrand_0.11.3_all.click: pass

  [Regression Potential]
  The regression potential is low since the fetching of apparmor is totally broken and causes a traceback.

  = Original description =

  WARNING:root:Ignoring missing framework "ubuntu-sdk-15.04"
  Now executing: click-review ./qsa3.nessita_0.2_all.click
  Traceback (most recent call last):
    File "/usr/bin/click-review", line 162, in <module>
      main()
    File "/usr/bin/click-review", line 156, in main
      results.run_all_checks(overrides)
    File "/usr/bin/click-review", line 110, in run_all_checks
      self._run_module_checks(module, overrides)
    File "/usr/bin/click-review", line 97, in _run_module_checks
      review.do_checks()
    File "/usr/lib/python3/dist-packages/clickreviews/common.py", line 384, in do_checks
      func()
    File "/usr/lib/python3/dist-packages/clickreviews/cr_security.py", line 691, in check_policy_groups
      if len(policy_groups) < 1:
  TypeError: object of type 'NoneType' has no len()
  Successfully built package in './qsa3.nessita_0.2_all.click'.

  This is because clickreviews/apparmor_policy.py has a link to ~click-
  reviewers instead of ~store-reviewers. This is fixed in r694

To manage notifications about this bug go to:
https://bugs.launchpad.net/click-reviewers-tools/+bug/1608943/+subscriptions