group.of.nepali.translators team mailing list archive

[Tim Gardner <tim.gardner@xxxxxxxxxxxxx>]

https://lists.ubuntu.com/archives/kernel-team/2016-September/080069.html

** Also affects: linux (Ubuntu Yakkety)
   Importance: Undecided
     Assignee: Taco Screen team (taco-screen-team)
       Status: New

** Also affects: linux (Ubuntu Xenial)
   Importance: Undecided
       Status: New

** Changed in: linux (Ubuntu Yakkety)
       Status: New => Fix Released

** Changed in: linux (Ubuntu Yakkety)
     Assignee: Taco Screen team (taco-screen-team) => (unassigned)

** Changed in: linux (Ubuntu Xenial)
       Status: New => In Progress

** Changed in: linux (Ubuntu Xenial)
     Assignee: (unassigned) => Tim Gardner (timg-tpi)

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1625986

Title:
  Stratton: ISST-LTE:UbuntuKVM: Failed to hotplug virtual devices to
  guest running Ubuntu 16.04.1 on UbuntuKVM16.04.1 #179

Status in linux package in Ubuntu:
  Fix Released
Status in linux source package in Xenial:
  In Progress
Status in linux source package in Yakkety:
  Fix Released

Bug description:
  == Comment: #0 - Frank P. Novak <fnovak@xxxxxxxxxx> - 2016-08-15 11:36:32 ==
  ---Problem Description---

  Briggs&Stratton GA1 mustfix
  IBM-ISST
  KVM
  Linux OS
  Ubuntu
  No milestone

  @garychengg garychengg

  @jackt-smc jackt-smc
  9 participants
  @haochanh
  @itskin
  @dougmill-ibm
  @rogerc-smc
  @nadiafry
  @drbrent
  @mzipse
  @garychengg
  @jackt-smc
  Notifications

  You?re receiving notifications because you?re subscribed to this repository.
  Lock conversation
  @haochanh
  haochanh commented 21 days ago

  On the HOST, I run this command and observe those error on the guest:
  root@micro:~# uname -a
  Linux micro 4.4.0-31-generic #50-Ubuntu SMP Wed Jul 13 00:05:18 UTC 2016 ppc64le ppc64le ppc64le GNU/Linux
  root@micro:~# ls -l /microg1-g2-xfs
  total 788760392
  -rw-r--r-- 1 libvirt-qemu kvm 21474836480 Jul 25 10:28 microg1.hotplug.img
  -rw-r--r-- 1 libvirt-qemu kvm 644245094400 Jul 25 10:53 microg1_lv.raw.img
  -rw-r--r-- 1 libvirt-qemu kvm 107374182400 Jul 25 10:53 microg1.raw.img
  -rw-r--r-- 1 libvirt-qemu kvm 370680332288 Jul 25 10:53 microg2_lv.qcow2.img
  -rw-r--r-- 1 libvirt-qemu kvm 84473282560 Jul 25 10:53 microg2.qcow2.img

  root@micro:~# virsh attach-disk microg1 --source
  /microg1-g2-xfs/microg1.hotplug.img --target vdd

  On the GUEST: I got this error and NO disk is added in.
  root@microg1:~# cat /var/log/kern.log |tail -30
  Jul 25 10:31:18 microg1 kernel: [242207.245064] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.245166] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.245241] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.245326] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.245413] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.245488] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.245564] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.245654] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.245732] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.245811] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.245898] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.245972] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.246046] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.246124] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.246198] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.246292] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.246363] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.246434] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.246508] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.246582] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.246656] rpaphp: pci_hp_register failed with error -16
  Jul 25 10:31:18 microg1 kernel: [242207.520069] pci 0000:00:04.0: [1af4:1001] type 00 class 0x010000
  Jul 25 10:31:18 microg1 kernel: [242207.520283] pci 0000:00:04.0: reg 0x10: [io 0x10000-0x1003f]
  Jul 25 10:31:18 microg1 kernel: [242207.520339] pci 0000:00:04.0: reg 0x14: [mem 0x00000000-0x00000fff]
  Jul 25 10:31:18 microg1 kernel: [242207.521180] iommu: Adding device 0000:00:04.0 to group 0
  Jul 25 10:31:18 microg1 kernel: [242207.521309] pci 0000:00:04.0: BAR 1: assigned [mem 0x100a0000000-0x100a0000fff]
  Jul 25 10:31:18 microg1 kernel: [242207.521391] pci 0000:00:04.0: BAR 0: assigned [io 0x10040-0x1007f]
  Jul 25 10:31:18 microg1 kernel: [242207.521527] virtio-pci 0000:00:04.0: enabling device (0000 -> 0003)
  Jul 25 10:31:18 microg1 kernel: [242207.522264] virtio-pci 0000:00:04.0: virtio_pci: leaving for legacy driver
  Jul 25 10:39:35 microg1 kernel: [242704.508536] XFS (loop0): Unmounting Filesystem
  @haochanh haochanh added the IBM-HST-ISST label 21 days ago
  @mzipse mzipse added the Linux OS / KVM label 21 days ago
  @garychengg garychengg was assigned by mzipse 21 days ago
  @jackt-smc jackt-smc was assigned by garychengg 21 days ago
  @dougmill-ibm dougmill-ibm added Ubuntu KVM labels 18 days ago
  @haochanh
  haochanh commented 14 days ago

  We try to add a virtual net device and got the same error "pci_hp_register failed with error -16" however the virtual NIC is added in.
  @nadiafry nadiafry added the Briggs&Stratton GA1 mustfix label 14 days ago
  @itskin
  itskin commented 13 days ago

  Approve System Test mustfix classification. Reason=While both hotplug of disk and network both generate same error message, at least NIC succeeds but disk consistently fails.
  @dougmill-ibm
  dougmill-ibm commented 13 days ago

  Note, error -16 is EBUSY. I have not yet found the circumstance(s) under which EBUSY is returned from pci_hp_register().
  @rogerc-smc
  rogerc-smc commented 11 days ago

  Not sure what I am missing, but I haven't been able to replicate the
  issue exactly:

  root@104-173:/mnt/a# ls -l
  total 527863828
  drwx------ 2 root root 16384 Aug 3 16:19 lost+found
  -rw-r--r-- 1 libvirt-qemu kvm 536953094144 Aug 3 18:28 data_disk.qcow2
  -rw-r--r-- 1 libvirt-qemu kvm 1791688704 Aug 4 10:31 os_disk.qcow2

  root@104-173:/mnt/a# virsh attach-disk Guest1_Xenial --source /mnt/a/data_disk.qcow2 --target vdd
  Disk attached successfully

  On the Guest OS, I am only getting this error:
  Aug 4 10:39:46 105-214 kernel: [ 253.633490] RTAS: event: 3, Type: Unknown, Severity: 1
  I also don't see any disk being added in until after I reboot the Guest.

  Also, if I switch up the attach-disk command a little bit:
  root@104-173:/mnt/a# virsh attach-disk Guest1_Xenial --source /mnt/a/data_disk.qcow2 --target sdc
  Disk attached successfully
  I no longer see an error in the Guest OS, although I still won't see any disk being added until I reboot the Guest.
  @haochanh
  haochanh commented 11 days ago

  The purpose of this hotplug is we can use the disk/nic live, without reboot the guest.
  Not sure why you do not see the pci_hp_register failed with error -16.
  @nadiafry
  nadiafry commented 10 days ago

  So, in a way, SuperMicro has recreated this bug as the disk wasn't showing up until after a guest reboot.
  @drbrent
  drbrent commented 6 days ago

  ISST updated to newer kernel, -34. Problem appears to be gone. IBM to test again. Close if not recreated.
  @haochanh
  haochanh commented 3 days ago

  I have verified the disk is added in without reboot the guest on -34 kernel.
  However, I still see this error "rpaphp: pci_hp_register failed with error -16" only on the first trial and it is gone on a consequence attempt until you reboot the guest then it shows up error again only on the 1st attempt.

  I run this command on the guest "tail -f /var/log/kern.log", 3 times attempt add/remove from the Host and collect the log below...
  microg1-hotplug.txt
  @haochanh
  haochanh commented 3 days ago

  The hotplug function is working, the error messages maybe harmless,
  annoying but it is there on the guest for the first time attempt to do
  hotplug. Please advise us on we should close this or not. Thanks.

  == Comment: #2 - TYREL N. DATWYLER <tyreld@xxxxxxxxxx> - 2016-08-16 11:29:20 ==
  In the past we have built the rpaphp code as a module and not auto-loaded it to avoid these messages in qemu guests. There is now an upstream patch that fixes this all together.

  commit e2413a7dae52fab290b7a8d11ec8579657bab95b
  Author: Tyrel Datwyler <tyreld@xxxxxxxxxxxxxxxxxx>
  Date:   Mon Jul 11 17:16:27 2016 -0500

      PCI: rpaphp: Fix slot registration for multiple slots under a PHB
      
      The underlying slot hotplug registration code assumed multiple slots, but
      the actual implementation is broken for multiple slots.
      
      This went unnoticed for years do to the fact that PowerVM seems to only
      ever provide a single hotplug slot per PHB.
      
      Under qemu/kvm the hotplug slot model aligns more with x86 where
      multiple slots are presented under a single PHB. As seen in the
      following each additional slot after the first fails to register due to
      each slot always being compared against the first child node of the PHB
      in the device tree.
      
        rpaphp: RPA HOT Plug PCI Controller Driver version: 0.1
        rpaphp: Slot [Slot 0] registered
        rpaphp: pci_hp_register failed with error -16
        rpaphp: pci_hp_register failed with error -16
        rpaphp: pci_hp_register failed with error -16
        rpaphp: pci_hp_register failed with error -16
      
      The registration logic is fixed so that each slot is compared
      against the existing child devices of the PHB in the device tree to
      determine present slots vs empty slots.
      
        rpaphp: RPA HOT Plug PCI Controller Driver version: 0.1
        rpaphp: Slot [C0] registered
        rpaphp: Slot [C1] registered
        rpaphp: Slot [C2] registered
        rpaphp: Slot [C3] registered
        rpaphp: Slot [C4] registered
      
      Signed-off-by: Tyrel Datwyler <tyreld@xxxxxxxxxxxxxxxxxx>
      Reviewed-by: Nathan Fontenot <nfont@xxxxxxxxxxxxxxxxxx>
      [mpe: Massage changelog]
      Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>

  == Comment: #5 - Scott E. Garfinkle <seg@xxxxxxxxxx> - 2016-08-23 19:20:14 ==
  Well, you can also see the patch at https://patchwork.kernel.org/patch/9224345/

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1625986/+subscriptions