group.of.nepali.translators team mailing list archive

[Dimitri John Ledkov <launchpad@xxxxxxxxxxxx>]

** Also affects: python-launchpadlib (Ubuntu)
   Importance: Undecided
       Status: New

** Also affects: python-launchpadlib (Ubuntu Xenial)
   Importance: Undecided
       Status: New

** Changed in: python-launchpadlib (Ubuntu)
       Status: New => Fix Released

** Changed in: python-launchpadlib (Ubuntu Xenial)
       Status: New => Triaged

** Changed in: python-launchpadlib (Ubuntu Xenial)
   Importance: Undecided => Medium

** Changed in: python-launchpadlib (Ubuntu Xenial)
     Assignee: (unassigned) => Dimitri John Ledkov (xnox)

** Changed in: python-launchpadlib (Ubuntu Xenial)
    Milestone: None => ubuntu-16.04.2

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1471894

Title:
  _bad_oauth_token crashes on python3 (str vs bytes)

Status in launchpadlib :
  Fix Released
Status in python-launchpadlib package in Ubuntu:
  Fix Released
Status in python-launchpadlib source package in Xenial:
  Triaged

Bug description:
  Hi

  Running something as simple as

  >>> from launchpadlib.launchpad import Launchpad
  >>> launchpad = Launchpad.login_with("app", "production")

  Results in a traceback such as this one:

  Traceback (most recent call last):
    File "./foo.py", line 31, in <module>
      lb = launchpad.projects[project]
    File "/usr/lib/python3/dist-packages/lazr/restfulclient/resource.py", line 1001, in __getitem__
      shim_resource._ensure_representation()
    File "/usr/lib/python3/dist-packages/lazr/restfulclient/resource.py", line 382, in _ensure_representation
      representation = self._root._browser.get(self._wadl_resource)
    File "/usr/lib/python3/dist-packages/lazr/restfulclient/_browser.py", line 436, in get
      response, content = self._request(url, extra_headers=headers)
    File "/usr/lib/python3/dist-packages/lazr/restfulclient/_browser.py", line 387, in _request
      str(url), method=method, body=data, headers=headers)
    File "/usr/lib/python3/dist-packages/lazr/restfulclient/_browser.py", line 357, in _request_and_retry
      url, method=method, body=body, headers=headers)
    File "/usr/lib/python3/dist-packages/httplib2/__init__.py", line 1291, in request
      (response, content) = self._request(conn, authority, uri, request_uri, method, body, headers, redirections, cachekey)
    File "/usr/lib/python3/dist-packages/launchpadlib/launchpad.py", line 132, in _request
      return self.retry_on_bad_token(response, content, *args)
    File "/usr/lib/python3/dist-packages/launchpadlib/launchpad.py", line 139, in retry_on_bad_token
      if (self._bad_oauth_token(response, content)
    File "/usr/lib/python3/dist-packages/launchpadlib/launchpad.py", line 125, in _bad_oauth_token
      (content.startswith("Expired token")
  TypeError: startswith first arg must be bytes or a tuple of bytes, not str

  
  This doesn't happen on python2. I will follow up with a patch shortly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/launchpadlib/+bug/1471894/+subscriptions