← Back to team overview

group.of.nepali.translators team mailing list archive

[Bug 1656048] Re: grub-installer might not install to the PReP partition of NVMe disks

 

This bug was fixed in the package grub-installer - 1.128ubuntu5.1

---------------
grub-installer (1.128ubuntu5.1) xenial; urgency=medium

  * grub-installer: deal with NVMe devices (or other devices with a partition
    separator) being used to back the PReP partition on ppc64el. (LP: #1656048)

 -- Mathieu Trudel-Lapierre <cyphermox@xxxxxxxxxx>  Fri, 13 Jan 2017
16:19:30 -0500

** Changed in: grub-installer (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1656048

Title:
  grub-installer might not install to the PReP partition of NVMe disks

Status in grub-installer package in Ubuntu:
  Fix Released
Status in grub-installer source package in Xenial:
  Fix Released

Bug description:
  [Impact]
  NVMe installs on ppc64el for PReP.

  [Test case]
  Attempt to install Ubuntu on a ppc64el where a PReP partition is required; make sure to put the new PReP partition on the NVMe disk. See Problem Description below.

  [Regression Potential]
  Any failure to install PReP on ppc64el on a system with NVMe should be considered a regression of this bug.

  ----

  == Comment: #0 - Mauricio Faria De Oliveira - 2017-01-12 05:22:08 ==
  ---Problem Description---
  On ppc64el, the grub-installer script attempts to detect which PReP partition is in the same disk as of the installed system, in order to install grub into it.

  This check is not working properly for NVMe devices, and needs an update.
  It might result in overwriting the PReP partition of another disk, possibly another Linux distro/version, which is unrelated to the current installation.

  Patches for Xenial and Zesty are attached.

  Problem example:
  ---

  - PReP partition actually is '/dev/nvme1n1p1'
  - PReP partition detected is '/dev/sda1'

      ~ # /usr/lib/grub-installer/prep-bootdev -l
      /dev/sda1
      /dev/nvme1n1p1
      /dev/nvme0n1p1

      ~ # grep grub-install /var/log/syslog
      ...
      Jan 11 22:17:25 main-menu[518]: INFO: Menu item 'grub-installer' selected
      Jan 11 22:17:25 grub-installer: info: architecture: ppc64el/chrp_ibm
      Jan 11 22:17:29 grub-installer: info: Identified partition label for /dev/nvme1n1p2: gpt
      Jan 11 22:17:29 grub-installer: info: Wiping PReP partition /dev/sda1
      ...
      Jan 11 22:17:33 grub-installer: info: Running chroot /target grub-install  --force "/dev/sda1"
      ...
      Jan 11 22:17:33 grub-installer: info: grub-install ran successfully

      ~ # in-target ofpathname /dev/sda1
      ~ # in-target nvram --print-config=boot-device

      ~ # tail -n2 /var/log/syslog
      ... in-target: /pci@800000020000015/pci1014,034A@0/sas/disk@5000c50067b1166b
      ... in-target: /pci@800000020000015/pci1014,034A@0/sas/disk@5000c50067b1166b

  Patch applied:
  ---

  ~ # grep grub-installer /var/log/syslog
  ...
  Jan 11 23:59:25 main-menu[518]: INFO: Menu item 'grub-installer' selected
  Jan 11 23:59:25 grub-installer: info: architecture: ppc64el/chrp_ibm
  Jan 11 23:59:27 grub-installer: info: Identified partition label for /dev/nvme1n1p2: gpt
  Jan 11 23:59:27 grub-installer: info: Wiping PReP partition /dev/nvme1n1p1
  ...
  Jan 11 23:59:30 grub-installer: info: Running chroot /target grub-install  --force "/dev/nvme1n1p1"
  ...
  Jan 11 23:59:31 grub-installer: info: grub-install ran successfully

      ~ # in-target nvram --print-config=boot-device
      ~ # tail -n1 /var/log/syslog
      ... in-target: /pci@800000020000028/pci1bb1,121@0/namespace@1

  After reboot of installation done:

      0 > printenv boot-device
      -------------- Partition: common -------- Signature: 0x70 ---------------
      boot-device              /pci@800000020000028/pci1bb1,121@0/namespace@1

  == Comment: #1 - Mauricio Faria De Oliveira <mauricfo@xxxxxxxxxx> - 2017-01-12 05:24:08 ==
  Patch for Xenial

  == Comment: #2 - Mauricio Faria De Oliveira <mauricfo@xxxxxxxxxx> - 2017-01-12 05:24:26 ==
  Patch for Zesty.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub-installer/+bug/1656048/+subscriptions