group.of.nepali.translators team mailing list archive

[ChristianEhrhardt <1644530@xxxxxxxxxxxxxxxxxx>]

Reported the request to pick up the PIDFile statement to Debian.
Linking up the debbug here.


** Bug watch added: Debian Bug tracker #857618
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857618

** Also affects: keepalived (Debian) via
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857618
   Importance: Unknown
       Status: Unknown

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1644530

Title:
  keepalived fails to restart cleanly due to the wrong systemd settings

Status in keepalived package in Ubuntu:
  Fix Released
Status in systemd package in Ubuntu:
  New
Status in keepalived source package in Xenial:
  Triaged
Status in systemd source package in Xenial:
  New
Status in keepalived package in Debian:
  Unknown

Bug description:
  Because "PIDFile=" directive is missing in the systemd unit file,
  keepalived sometimes fails to kill all old processes. The old
  processes remain with old settings and cause unexpected behaviors. The
  detail of this bug is described in this ticket in upstream:
  https://github.com/acassen/keepalived/issues/443.

  The official systemd unit file is available since version 1.2.24 by
  this commit:

  https://github.com/acassen/keepalived/commit/635ab69afb44cd8573663e62f292c6bb84b44f15

  This includes "PIDFile" directive correctly:

  PIDFile=/var/run/keepalived.pid

  We should go the same way.

  I am using Ubuntu 16.04.1, kernel 4.4.0-45-generic.

  Package: keepalived
  Version: 1.2.19-1

  =======================================================================

  How to reproduce:

  I used the two instances of Ubuntu 16.04.2 on DigitalOcean:

  Configurations
  --------------

  MASTER server's /etc/keepalived/keepalived.conf:

    vrrp_script chk_nothing {
       script "/bin/true"
       interval 2
    }

    vrrp_instance G1 {
      interface eth1
      state BACKUP
      priority 100

      virtual_router_id 123
      unicast_src_ip <primal IP>
      unicast_peer {
        <secondal IP>
      }
      track_script {
        chk_nothing
      }
    }

  BACKUP server's /etc/keepalived/keepalived.conf:

    vrrp_script chk_nothing {
       script "/bin/true"
       interval 2
    }

    vrrp_instance G1 {
      interface eth1
      state MASTER
      priority 200

      virtual_router_id 123
      unicast_src_ip <secondal IP>
      unicast_peer {
        <primal IP>
      }
      track_script {
        chk_nothing
      }
    }

  Loop based probing for the Error to exist:
  ------------------------------------------
  After the setup above start keepalived on both servers:
      $ sudo systemctl start keepalived.service
  Then run the following loop
      $ for j in $(seq 1 20); do sleep 11s; time for i in $(seq 1 5); do sudo systemctl restart keepalived; sudo systemctl status keepalived | egrep 'Main.*exited'; done; done

  Expected: no error, only time reports
  Error case: Showing Main PID exited, details below

  Step by Step Procedures
  -----------------------

  1) Start keepalived on both servers

    $ sudo systemctl start keepalived.service

  2) Restart keepalived on either one

    $ sudo systemctl restart keepalived.service

  3) Check status and PID

    $ systemctl status -n0 keepalived.service

  Result
  ------

  0) Before restart

  Main PID is 3402 and the subprocesses' PIDs are 3403-3406. So far so
  good.

    root@ubuntu-2gb-sgp1-01:~# systemctl status -n0 keepalived
    ● keepalived.service - Keepalive Daemon (LVS and VRRP)
       Loaded: loaded (/lib/systemd/system/keepalived.service; enabled; vendor preset: enabled)
       Active: active (running) since Sat 2017-03-04 01:37:12 UTC; 14min ago
      Process: 3402 ExecStart=/usr/sbin/keepalived $DAEMON_ARGS (code=exited, status=0/SUCCESS)
     Main PID: 3403 (keepalived)
        Tasks: 3
       Memory: 1.7M
          CPU: 1.900s
       CGroup: /system.slice/keepalived.service
               ├─3403 /usr/sbin/keepalived
               ├─3405 /usr/sbin/keepalived
               └─3406 /usr/sbin/keepalived

  1) First restart

  Now Main PID is 3403, which was one of the previous subprocesses and
  is actually exited. Something is wrong. Yet, the previous processes
  are all exited; we are not likely to see no weird behaviors here.

    root@ubuntu-2gb-sgp1-01:~# systemctl restart keepalived
    root@ubuntu-2gb-sgp1-01:~# systemctl status -n0 keepalived
    ● keepalived.service - Keepalive Daemon (LVS and VRRP)
       Loaded: loaded (/lib/systemd/system/keepalived.service; enabled; vendor preset: enabled)
       Active: active (running) since Sat 2017-03-04 01:51:45 UTC; 1s ago
      Process: 4782 ExecStart=/usr/sbin/keepalived $DAEMON_ARGS (code=exited, status=0/SUCCESS)
     Main PID: 3403 (code=exited, status=0/SUCCESS)
        Tasks: 3
       Memory: 1.7M
          CPU: 11ms
       CGroup: /system.slice/keepalived.service
               ├─4783 /usr/sbin/keepalived
               ├─4784 /usr/sbin/keepalived
               └─4785 /usr/sbin/keepalived

  2) Second restart

  Now Main PID is 4783 and subprocesses' PIDs are 4783-4785. This is
  problematic as 4783 is the old process, which should have exited
  before new processes arose. Therefore, keepalived remains in old
  settings while users believe it uses the new setting.

    root@ubuntu-2gb-sgp1-01:~# systemctl restart keepalived
    root@ubuntu-2gb-sgp1-01:~# systemctl status -n0 keepalived
    ● keepalived.service - Keepalive Daemon (LVS and VRRP)
       Loaded: loaded (/lib/systemd/system/keepalived.service; enabled; vendor preset: enabled)
       Active: active (running) since Sat 2017-03-04 01:51:49 UTC; 1s ago
      Process: 4796 ExecStart=/usr/sbin/keepalived $DAEMON_ARGS (code=exited, status=0/SUCCESS)
     Main PID: 4783 (keepalived)
        Tasks: 3
       Memory: 1.7M
          CPU: 6ms
       CGroup: /system.slice/keepalived.service
               ├─4783 /usr/sbin/keepalived
               ├─4784 /usr/sbin/keepalived
               └─4785 /usr/sbin/keepalived

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/keepalived/+bug/1644530/+subscriptions