group.of.nepali.translators team mailing list archive

[Brad Figg <brad.figg@xxxxxxxxxxxxx>]

** Changed in: linux (Ubuntu)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1632786

Title:
  [Hyper-V] do not lose pending heartbeat vmbus packets

Status in linux package in Ubuntu:
  Fix Released
Status in linux source package in Precise:
  Fix Released
Status in linux source package in Trusty:
  Fix Released
Status in linux source package in Vivid:
  Fix Released
Status in linux source package in Xenial:
  Fix Released
Status in linux source package in Yakkety:
  Fix Released

Bug description:
  Hyper-V hosts can continue sending heartbeat packets to guests
  independent of whether earlier packets have responses, which led to a
  potential issue of these packets being dropped when responses took too
  long to process. Lost heartbeats will lead to the host diagnosing that
  the guest is dead and should be shut down and restarted.

  The following patch was submitted upstream but has not yet been
  accepted. I will add the upstream commit ID once the patch goes into
  linux-next:

  From: Long Li <longli@xxxxxxxxxxxxx>

  The host keeps sending heartbeat packets independent of the
  guest responding to them.  Even though we respond to the heartbeat messages at
  interrupt level, we can have situations where there maybe multiple heartbeat
  messages pending that have not been responded to. For instance this occurs when the
  VM is paused and the host continues to send the heartbeat messages.
  Address this issue by draining and responding to all
  the heartbeat messages that maybe pending.

  Signed-off-by: Long Li <longli@xxxxxxxxxxxxx>
  Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
  CC: Stable <stable@xxxxxxxxxxxxxxx>
  ---
          V2: Submit the patch to stable as well - Joshua R. Poulson <jrp@xxxxxxx>

   drivers/hv/hv_util.c |   10 +++++++---
   1 files changed, 7 insertions(+), 3 deletions(-)

  diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
  index 4aa3cb6..bcd0630 100644
  --- a/drivers/hv/hv_util.c
  +++ b/drivers/hv/hv_util.c
  @@ -314,10 +314,14 @@ static void heartbeat_onchannelcallback(void *context)
          u8 *hbeat_txf_buf = util_heartbeat.recv_buffer;
          struct icmsg_negotiate *negop = NULL;

  -       vmbus_recvpacket(channel, hbeat_txf_buf,
  -                        PAGE_SIZE, &recvlen, &requestid);
  +       while (1) {
  +
  +               vmbus_recvpacket(channel, hbeat_txf_buf,
  +                                PAGE_SIZE, &recvlen, &requestid);
  +
  +               if (!recvlen)
  +                       break;

  -       if (recvlen > 0) {
                  icmsghdrp = (struct icmsg_hdr *)&hbeat_txf_buf[
                                  sizeof(struct vmbuspipe_hdr)];

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1632786/+subscriptions