group.of.nepali.translators team mailing list archive

[Andy Whitcroft <apw@xxxxxxxxxxxxx>]

** Also affects: ubuntu-fan (Ubuntu Xenial)
   Importance: Undecided
       Status: New

** Also affects: ubuntu-fan (Ubuntu Yakkety)
   Importance: Undecided
       Status: New

** Changed in: ubuntu-fan (Ubuntu Xenial)
       Status: New => In Progress

** Changed in: ubuntu-fan (Ubuntu Yakkety)
       Status: New => In Progress

** Changed in: ubuntu-fan (Ubuntu Xenial)
   Importance: Undecided => Medium

** Changed in: ubuntu-fan (Ubuntu Yakkety)
   Importance: Undecided => Medium

** Changed in: ubuntu-fan (Ubuntu Xenial)
     Assignee: (unassigned) => Stefan Bader (smb)

** Changed in: ubuntu-fan (Ubuntu Yakkety)
     Assignee: (unassigned) => Stefan Bader (smb)

** Changed in: ubuntu-fan (Ubuntu Zesty)
     Assignee: (unassigned) => Stefan Bader (smb)

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1691485

Title:
  fanatic disable-fan fails without docker installed

Status in ubuntu-fan package in Ubuntu:
  Fix Released
Status in ubuntu-fan source package in Xenial:
  In Progress
Status in ubuntu-fan source package in Yakkety:
  In Progress
Status in ubuntu-fan source package in Zesty:
  Fix Released

Bug description:
  Release: 17.04/Zesty
  Version: 0.12.2

  When disabling fan, the code tries to check whether docker is
  configured. However that test is attempting to decide which docker
  version is installed (in order to handle the new network options).
  This fails but is incorrectly evaluated as docker being configured.
  And that prevents fan from being de-configured.

  Fix: Test for docker being installed and if not return false to the
  configured check.

  SRU Justification:

  Impact: The function which does docker config updates/tests currently
  does not check for the presence of the docker command itself. And
  while there are error messages to stderr a call to check for fan being
  configured for docker accidentally results in returning true.

  Fix: Adding a check for the docker command being present early in the
  function and return an error in that case (which is a false in the is-
  docker-configured case). Since the function should really always fail
  if there is no docker present the risk of regressions should be low.

  Testcase:
   - [docker is not installed]
   - fanatic enable-fan ...
   - fanatic disable-fan ...

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-fan/+bug/1691485/+subscriptions