group.of.nepali.translators team mailing list archive

[Launchpad Bug Tracker <1685944@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package cloud-init - 0.7.9-153-g16a7302f-
0ubuntu1~16.10.1

---------------
cloud-init (0.7.9-153-g16a7302f-0ubuntu1~16.10.1) yakkety-proposed; urgency=medium

  * New upstream snapshot.
    - net: fix reading and rendering addresses in cidr format.
      [Dimitri John Ledkov] (LP: #1689346, #1684349)
    - disk_setup: udev settle before attempting partitioning or fs creation.
      (LP: #1692093)
    - GCE: Update the attribute used to find instance SSH keys.
      [Daniel Watkins] (LP: #1693582)
    - nplan: For bonds, allow dashed or underscore names of keys.
      [Dimitri John Ledkov] (LP: #1690480)
    - tests: python2.6: fix unit tests usage of assertNone and format.
    - tests: update docstring on test_configured_list_with_none
    - fix tools/ds-identify to not write None twice.
    - tox/build: do not package depend on style requirements.
    - tests: ntp: Restructure cc_ntp unit tests. [Chad Smith]
    - flake8: move the pinned version of flake8 up to 3.3.0
    - tests: Apply workaround for snapd bug in test case. [Joshua Powers]
    - RHEL/CentOS: Fix dual stack IPv4/IPv6 configuration.  [Andreas Karis]
    - disk_setup: fix several issues with gpt disk partitions. (LP: #1692087)
    - function spelling & docstring update [Joshua Powers]
    - tests: Fix unittest bug in ntp tests. [Joshua Powers]
    - tox: move pylint target to 1.7.1
    - Fix get_interfaces_by_mac for empty macs (LP: #1692028)
    - DigitalOcean: remove routes except for the public interface.
      [Ben Howard] (LP: #1681531.)
    - netplan: pass macaddress, when specified, for vlans
      [Dimitri John Ledkov] (LP: #1690388)
    - doc: various improvements for the docs on cc_users_groups.
      [Felix Dreissig]
    - cc_ntp: write template before installing and add service restart
      [Ryan Harper] (LP: #1645644)
    - tests: fix cloudstack unit tests to avoid accessing
      /var/lib/NetworkManager [Lars Kellogg-Stedman]
    - tests: fix hardcoded path to mkfs.ext4 [Joshua Powers] (LP: #1691517)
    - Actually skip warnings when .skip file is present.
      [Chris Brinker] (LP: #1691551)
    - netplan: fix netplan render_network_state signature.
      [Dimitri John Ledkov] (LP: #1685944)
    - Azure: fix reformatting of ephemeral disks on resize to large types.
      (LP: #1686514)
    - make deb: Add devscripts dependency for make deb.
      Cleanup packages/bddeb. [Chad Smith] (LP: #1685935)
    - openstack: fix log message copy/paste typo in _get_url_settings
      [Lars Kellogg-Stedman]
    - unittests: fix unittests run on centos [Joshua Powers]
    - Improve detection of snappy to include os-release and kernel cmdline.
      (LP: #1689944)
    - Add address to config entry generated by _klibc_to_config_entry.
      [Julien Castets] (LP: #1691135)
    - sysconfig: Raise ValueError when multiple default gateways are present.
      [Chad Smith] (LP: #1687485)
    - FreeBSD: improvements and fixes for use on Azure
      [Hongjiang Zhang] (LP: #1636345)
    - Add unit tests for ds-identify, fix Ec2 bug found.
    - fs_setup: if cmd is specified, use shell interpretation.
      [Paul Meyer] (LP: #1687712)
    - doc: document network configuration defaults policy and formats.
      [Ryan Harper]
    - doc: Fix name of "uri" key in docs for "cc_apt_configure" module
      [Felix Dreissig]
    - tests: Enable artful in integration tests [Joshua Powers]

 -- Scott Moser <smoser@xxxxxxxxxx>  Fri, 26 May 2017 16:08:21 -0400

** Changed in: cloud-init (Ubuntu Yakkety)
       Status: Fix Committed => Fix Released

** Changed in: cloud-init (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1685944

Title:
  tools/net-convert: fix argument order for render_network_state

Status in cloud-init:
  Fix Committed
Status in cloud-init package in Ubuntu:
  Fix Released
Status in cloud-init source package in Xenial:
  Fix Released
Status in cloud-init source package in Yakkety:
  Fix Released
Status in cloud-init source package in Zesty:
  Fix Released

Bug description:
  === Begin SRU Template ===
  [Impact] 
  Rendering of netplan content was broken due to an incorrect
  function signature in net/netplan.py:render_network_state.

  The end result was that rendering of netplan configuration was
  broken in actual usage.  Note, though that no official Ubuntu images
  use this path at the current time.  Ubuntu image all use ifupdown.

  [Test Case]
  The basic idea below is:
   a.) launch an instance with proposed version of cloud-init.
   b.) inside instance, run the test case.  That would stack trace
       as seen in the bug on prior versions of cloud-init.
   c.) show the output.

  ## launch an instance.
  $ release=xenial
  $ ref=$release-proposed
  $ lxc-proposed-snapshot --proposed --publish $release $ref
  $ lxc launch $ref $name
  $ lxc exec $name

  % cat > render-test.py <<"EOF"
  #!/usr/bin/python3
  import sys
  from cloudinit.net import netplan, eni, network_state
  out_d = "./out.d" if len(sys.argv) < 2 else sys.argv[1]

  cfg = {'version': 1,
         'config': [{'name': 'eth1', 'type': 'physical',
                    'subnets': [{'type': 'dhcp'}]}]}

  # Render eni and netplan to show that they both work.
  ns = network_state.parse_net_config_data(cfg)
  for renderer in netplan.Renderer(), eni.Renderer():
      print("Rendering %s" % renderer)
      renderer.render_network_state(ns, out_d)
  EOF

  $ python3 render-test.py out.d
  Rendering <cloudinit.net.netplan.Renderer object at 0x7fd197c48208>
  Rendering <cloudinit.net.eni.Renderer object at 0x7fd197c48278>

  $ ( cd out.d && for f in $(find . -type f); do echo == $f ==; cat $f; done )
  == ./etc/network/interfaces ==
  auto lo
  iface lo inet loopback

  auto eth1
  iface eth1 inet dhcp
  == ./etc/netplan/50-cloud-init.yaml ==
  network:
      version: 2
      ethernets:
          eth1:
              dhcp4: true
  == ./etc/udev/rules.d/70-persistent-net.rules ==

  $ dpkg-query --show cloud-init

  [Regression Potential] 
  This specific change has basically zero regression potential as it
  was in netplan specific path that was only previously excercised
  with test cases.

  [Other Info]
  Upstream commit at
    https://git.launchpad.net/cloud-init/commit/?id=a6572d9415e59

  lxc-proposed-snapshot is
    https://git.launchpad.net/~smoser/cloud-init/+git/sru-info/tree/bin/lxc-proposed-snapshot
  It publishes an image to lxd with proposed enabled and cloud-init upgraded.
  === End SRU Template ===

  
  % cat simple-v2.yaml
  network:
    version: 2
    # comment above ethernets
    ethernets:
        ens0:
           dhcp4: true
           match:
             macaddress: 00:11:22:33:44:55
           set-name: ens0
        switchports:
          # all cards on second PCI bus; unconfigured by themselves, will be added
          # to br0 below
          match:
            name: enp2*
          mtu: 1280

  % PYTHONPATH=`pwd` ./tools/net-convert.py --network-data simple-v2.yaml \
                                            --kind yaml \
                                            --output-kind netplan \
                                            --directory ./target

  Traceback (most recent call last):
    File "./tools/net-convert.py", line 82, in <module>
      main()
    File "./tools/net-convert.py", line 78, in main
      r.render_network_state(ns, target=args.directory)
  TypeError: render_network_state() got multiple values for argument 'target'

  This is broken on master.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1685944/+subscriptions