group.of.nepali.translators team mailing list archive

[dann frazier <dann.frazier@xxxxxxxxxxxxx>]

@Manoj: While the code in the patch looks fine, I do see a couple issues
with the DEP-3 headers:

>Description: Remove version from list
> We can't reliably map controller registers due to kernel memory
> protections added in kernel commit 90a545e98, so we are removing its
> dependency for the 'list' command to run.
> Author: Keith Busch <keith.busch@xxxxxxxxx>

I'd suggest starting with the git commit, including all the metadata,
and adding the DEP-3 specific fields (Origin, Bug) to the end of the
header.

> Origin: upstream, https://github.com/linux-nvme/nvme-cli

Origin should be the URL of the commit, not the repository.

> Bug: https://launchpad.net/bugs/##

This isn't a valid URL, and it should be a pointer to the upstream bug,
if one exists. The "Bug-Ubuntu" field should be used to provide a
pointer to the Ubuntu bug in LP.

> Forwarded: not-needed

Well, technically it *is* needed since it was applied upstream. I'd
suggest just omitting this field though, it only really makes sense if
it is a vendor-specific patch.


** Changed in: nvme-cli (Ubuntu Xenial)
     Assignee: (unassigned) => Manoj Iyer (manjo)

** No longer affects: nvme-cli (Ubuntu Zesty)

** Changed in: nvme-cli (Ubuntu Xenial)
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1704817

Title:
  [Xenial] nvme-cli does not recognize version 1.0 NVME drives

Status in nvme-cli package in Ubuntu:
  Fix Released
Status in nvme-cli source package in Xenial:
  Confirmed

Bug description:
  [Impact]
  We've noticed that the nvme-cli package does not work on QDF2400 and gives the false impression that the hardware is broken. This prevents customers from running NVMe diagnostics. 

  [Test Case]
  Current version available -
  ubuntu@ubuntu:~$ sudo nvme version
  nvme version 0.5

  Current failure mode -
  root@ubuntu:/home/ubuntu# nvme list
  nvme0 did not find a pci resource

  Known issue: https://github.com/linux-nvme/nvme-cli/issues/81

  [Fix]
  Backport patch https://github.com/linux-nvme/nvme-cli/commit/6ab2e9ef204053d82c1eb40e514119286749cefe

  [Regression Potential]
  None. This was tested by QTI on Version 1.0 card and by Canonical on Version 1.2 card.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nvme-cli/+bug/1704817/+subscriptions