← Back to team overview

group.of.nepali.translators team mailing list archive

[Bug 1717825] [NEW] Switch from Ubuntu One dialog in plugins and use standard dialog

 

Public bug reported:

[Impact]
In GNOME Software 3.20 (Xenial) we have an Ubuntu One dialog that runs inside the plugins. GNOME 3.22 implemented a authentication dialog into the GNOME Software code in 3.22 (based on our dialog) which we switched to using. The dialog support was backported into 3.20.5.

When the current dialog is run it runs from a different thread to the
main UI. GTK+ is not thread safe and so this is likely to cause random
crashes. May be the cause of bugs like bug 1614130.

[Test Case 1]
1. Delete any existing Ubuntu One credentials by running seahorse and deleting keys named com.ubuntu.UbuntuOne.*
2. Open GNOME Software
3. Remove a snap

Expected result:
- The Ubuntu One dialog shows, works and the snap is removed

[Test Case 2]
1. Delete any existing Ubuntu One credentials by running seahorse and deleting keys named com.ubuntu.UbuntuOne.*
2. Open GNOME Software
3. Write an app review

Expected result:
- The Ubuntu One dialog shows, works and the review is written.

NOTE: Pick an app with few reviews so you can see your one that is
added. May need to restart GNOME Software to see review (this is
existing behaviour).

[Regression Potential]
Change is non-trivial, though the dialog code has been used in GNOME Software 3.22 and onwards. Some risk of breaking related code.

** Affects: gnome-software (Ubuntu)
     Importance: Medium
         Status: Fix Released

** Affects: gnome-software (Ubuntu Xenial)
     Importance: Medium
     Assignee: Robert Ancell (robert-ancell)
         Status: Triaged

** Also affects: gnome-software (Ubuntu Xenial)
   Importance: Undecided
       Status: New

** Changed in: gnome-software (Ubuntu)
       Status: New => Fix Released

** Changed in: gnome-software (Ubuntu)
   Importance: Undecided => Medium

** Changed in: gnome-software (Ubuntu Xenial)
   Importance: Undecided => Medium

** Changed in: gnome-software (Ubuntu Xenial)
       Status: New => Triaged

** Changed in: gnome-software (Ubuntu Xenial)
     Assignee: (unassigned) => Robert Ancell (robert-ancell)

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1717825

Title:
  Switch from Ubuntu One dialog in plugins and use standard dialog

Status in gnome-software package in Ubuntu:
  Fix Released
Status in gnome-software source package in Xenial:
  Triaged

Bug description:
  [Impact]
  In GNOME Software 3.20 (Xenial) we have an Ubuntu One dialog that runs inside the plugins. GNOME 3.22 implemented a authentication dialog into the GNOME Software code in 3.22 (based on our dialog) which we switched to using. The dialog support was backported into 3.20.5.

  When the current dialog is run it runs from a different thread to the
  main UI. GTK+ is not thread safe and so this is likely to cause random
  crashes. May be the cause of bugs like bug 1614130.

  [Test Case 1]
  1. Delete any existing Ubuntu One credentials by running seahorse and deleting keys named com.ubuntu.UbuntuOne.*
  2. Open GNOME Software
  3. Remove a snap

  Expected result:
  - The Ubuntu One dialog shows, works and the snap is removed

  [Test Case 2]
  1. Delete any existing Ubuntu One credentials by running seahorse and deleting keys named com.ubuntu.UbuntuOne.*
  2. Open GNOME Software
  3. Write an app review

  Expected result:
  - The Ubuntu One dialog shows, works and the review is written.

  NOTE: Pick an app with few reviews so you can see your one that is
  added. May need to restart GNOME Software to see review (this is
  existing behaviour).

  [Regression Potential]
  Change is non-trivial, though the dialog code has been used in GNOME Software 3.22 and onwards. Some risk of breaking related code.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1717825/+subscriptions