← Back to team overview

group.of.nepali.translators team mailing list archive

[Bug 1729034] Re: don't short-circuit update-grub kernel postinst hook in containers

 

This bug was fixed in the package livecd-rootfs - 2.408.22

---------------
livecd-rootfs (2.408.22) xenial; urgency=medium

  * Make sure to remove any initramfs that was generated in a minimized
    image.
  * divert /usr/bin/systemd-detect-virt as part of the grub diversions, so
    that the grub kernel postinst hook is operational when we're building
    in a container.  LP: #1729034.

 -- Steve Langasek <steve.langasek@xxxxxxxxxx>  Sat, 21 Oct 2017
20:53:02 -0700

** Changed in: livecd-rootfs (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1729034

Title:
  don't short-circuit update-grub kernel postinst hook in containers

Status in livecd-rootfs package in Ubuntu:
  Fix Released
Status in livecd-rootfs source package in Xenial:
  Fix Released

Bug description:
  [SRU Justification]
  LP: #1060404 was addressed by making the update-grub kernel postinst hook a no-op when running in containers.

  We now do all of our livefs builds in containers in Launchpad; this
  means livefses no longer get a grub config automatically generated
  with the correct contents when installing a kernel in the target, as
  they did previously.

  The change for LP: #1060404 was described by Colin as a "temporary
  fix".

  We know that update-grub itself now succeeds in the launchpad buildd
  containers, because we have several points in livefs builds where we
  are invoking it directly and it does what we expect.  And in any
  containers where update-grub does not work, these same livefs builds
  will fail anyway.

  [Test case]
  Run through a standard set of xenial image builds with livecd-rootfs in launchpad, including the private cloud image builds.  Confirm that the builds are successful and that the resulting images list the correct contents in /boot/grub/grub.cfg.

  [Regression potential]
  If something else relied on container detection in order to modify its behavior, and is called between the addition and removal of the systemd-detect-virt diversion, it could now behave incorrectly in a container and cause build failures.  This is an entirely hypothetical scenario, since all current consumers of (un)divert_grub, and pending users of it, have it very narrowly scoped such that they're only doing update-grub / kernel install operations in between.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1729034/+subscriptions