group.of.nepali.translators team mailing list archive

Thread
Date

[Bug 1728050] Re: fanatic enable-fan does not clean up config after failed bringup

To: group.of.nepali.translators@xxxxxxxxxxxxxxxxxxx
From: Launchpad Bug Tracker <1728050@xxxxxxxxxxxxxxxxxx>
Date: Mon, 11 Dec 2017 15:06:20 -0000
Reply-to: Bug 1728050 <1728050@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

This bug was fixed in the package ubuntu-fan - 0.12.8~17.10.1

---------------
ubuntu-fan (0.12.8~17.10.1) artful; urgency=medium

  * fanatic: Optionally provide DNS server for docker test (LP:
#1732717)

ubuntu-fan (0.12.7~17.10.1) artful; urgency=medium

  * fanctl: cmd_up needs to proparate scan_config errors (LP: #1719644)
  * fanatic: Clean up config if bringup fails (LP: #1728050)

 -- Stefan Bader <stefan.bader@xxxxxxxxxxxxx>  Wed, 29 Nov 2017 11:00:50
+0100

** Changed in: ubuntu-fan (Ubuntu Artful)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1728050

Title:
  fanatic enable-fan does not clean up config after failed bringup

Status in ubuntu-fan package in Ubuntu:
  Fix Released
Status in ubuntu-fan source package in Xenial:
  Fix Committed
Status in ubuntu-fan source package in Zesty:
  Fix Released
Status in ubuntu-fan source package in Artful:
  Fix Released

Bug description:
  SRU Justification (for Artful/Zesty/Xenial):

  Impact:
  "fanatic enable-fan" calls to fanctl to actually bring up the Fan bridge. However it is possible that this returns with an error and in that case fanatic must undo previously done configuration changes or otherwise any following attempt to run enable-fan will incorrectly believe the bridge is up and do nothing.

  Fix:
  Adding a remove config stage if the call to fanctl returns with an error.

  Testcase:
    [fan is installed but not enabled]
    - sudo flock -x /run/xtables.lock sleep 300
    - fanatic enable-fan -u 192.168.0.0/16 -o 250.0.0.0/8; echo $?

  Note: It seems in Artful, the default for iptables is to wait until
  the lock is released (without -w) so the test here won't work without
  adding -w to all iptables calls in fanctl. :/

  Regression potential:
  Cleanup called only on failure and the used function is also used in fanatic disable-fan. -> Low

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-fan/+bug/1728050/+subscriptions