group.of.nepali.translators team mailing list archive

Thread
Date

[Bug 1745130] Re: Support rfkill-any led trigger for Fujitsu u727

To: group.of.nepali.translators@xxxxxxxxxxxxxxxxxxx
From: Joseph Salisbury <joseph.salisbury@xxxxxxxxxxxxx>
Date: Fri, 02 Feb 2018 14:26:04 -0000
Reply-to: Bug 1745130 <1745130@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

SRU Request submitted:
https://lists.ubuntu.com/archives/kernel-team/2018-February/089892.html

** No longer affects: linux (Ubuntu Trusty)

** Description changed:

+ == SRU Justification ==
+ This bug was reported against a Fujitsu u7x7 laptop series based on Skylake hardware.
+ It has a single rfkill button and a single LED for wlan and bluetooth. Both
+ drivers currently provide a single rfkill trigger, so the led could
+ just be assigned to one. This was resolved by mainline commit 9b8e34e211, which added a
+ "rfkill-any" led trigger to correctly handle the led with multiple
+ rfkill devices. That was added by one of the fujitsu-laptop maintainers and
+ the driver sets it as the default trigger.
+
+ Commit 9b8e34e211b1 is in mainline as of 4.11-rc1.
+
+ == Fix ==
+ commit 9b8e34e211b15af429b72388a8f2b3b1823d172e
+ Author: Michał Kępień <kernel@xxxxxxxxxx>
+ Date: Fri Jan 6 07:07:47 2017 +0100
+
+ rfkill: Add rfkill-any LED trigger
+
+ == Regression Potential ==
+ Medium. This commit affects all arches, but it has been in mainline since
+ 4.11-rc1 with no reported issues.
+
+ == Test Case ==
+ A test kernel was built with this patch and tested by the original bug reporter.
+ The bug reporter states the test kernel resolved the bug.
+
+
+ == Original Bug Description ==
I got new HW from our supplier, which is the Fujitsu u7x7 laptop series based on Skylake hardware.
It has a single rfkill button and a single LED for wlan and bluetooth. Both device driver currently provide a single rfkill trigger, so the led could just be assigned to one. As a result the upstream kernel got a new "rfkill-any" led trigger to correctly handle the led with multiple rfkill devices. That was added by one of the fujitsu-laptop maintainers and the driver sets it as the default trigger.

commit 9b8e34e211b15af429b72388a8f2b3b1823d172e
Author: Michał Kępień <kernel@xxxxxxxxxx>
Date: Fri Jan 6 07:07:47 2017 +0100

- rfkill: Add rfkill-any LED trigger
+ rfkill: Add rfkill-any LED trigger

Normally I would simply patch the affected modules using DKMS, like the i915_bpo driver, fujitsu-laptop and snd_hda_codec_realtek to support the HW without messing with the kernel packages.
I'm currently waiting for some reviews, like https://www.spinics.net/lists/platform-driver-x86/msg14606.html

But the rfkill support is compiled in, so I can't patch it using DKMS.

So my first proposed fix would be to include a backport of this patch.
Alternatively rfkill can be compiled as a module, so I can patch it and
provide an updated module.

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: linux-image-4.4.0-111-generic 4.4.0-111.134~14.04.1
ProcVersionSignature: Ubuntu 4.4.0-111.134~14.04.1-generic 4.4.98
Uname: Linux 4.4.0-111-generic i686
ApportVersion: 2.14.1-0ubuntu3.27
Architecture: i386
Date: Wed Jan 24 10:48:28 2018
SourcePackage: linux-lts-xenial
UpgradeStatus: No upgrade log present (probably fresh install)

--
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1745130

Title:
Support rfkill-any led trigger for Fujitsu u727

Status in linux package in Ubuntu:
In Progress
Status in linux source package in Xenial:
In Progress

Bug description:
== SRU Justification ==
This bug was reported against a Fujitsu u7x7 laptop series based on Skylake hardware.
It has a single rfkill button and a single LED for wlan and bluetooth. Both
drivers currently provide a single rfkill trigger, so the led could
just be assigned to one. This was resolved by mainline commit 9b8e34e211, which added a
"rfkill-any" led trigger to correctly handle the led with multiple
rfkill devices. That was added by one of the fujitsu-laptop maintainers and
the driver sets it as the default trigger.

Commit 9b8e34e211b1 is in mainline as of 4.11-rc1.

== Fix ==
commit 9b8e34e211b15af429b72388a8f2b3b1823d172e
Author: Michał Kępień <kernel@xxxxxxxxxx>
Date: Fri Jan 6 07:07:47 2017 +0100

rfkill: Add rfkill-any LED trigger

== Regression Potential ==
Medium. This commit affects all arches, but it has been in mainline since
4.11-rc1 with no reported issues.

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.

== Original Bug Description ==
I got new HW from our supplier, which is the Fujitsu u7x7 laptop series based on Skylake hardware.
It has a single rfkill button and a single LED for wlan and bluetooth. Both device driver currently provide a single rfkill trigger, so the led could just be assigned to one. As a result the upstream kernel got a new "rfkill-any" led trigger to correctly handle the led with multiple rfkill devices. That was added by one of the fujitsu-laptop maintainers and the driver sets it as the default trigger.

commit 9b8e34e211b15af429b72388a8f2b3b1823d172e
Author: Michał Kępień <kernel@xxxxxxxxxx>
Date: Fri Jan 6 07:07:47 2017 +0100

rfkill: Add rfkill-any LED trigger

But the rfkill support is compiled in, so I can't patch it using DKMS.

So my first proposed fix would be to include a backport of this patch.
Alternatively rfkill can be compiled as a module, so I can patch it
and provide an updated module.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1745130/+subscriptions