← Back to team overview

group.of.nepali.translators team mailing list archive

[Bug 1699659] Re: phpquery always returns 0

 

This bug was fixed in the package php-defaults - 35ubuntu6.1

---------------
php-defaults (35ubuntu6.1) xenial; urgency=medium

  * phpquery: Don't lose status from check_mod() (Closes #834189).
    - Backport from 44.
    - LP: #1699659.

 -- Nishanth Aravamudan <nish.aravamudan@xxxxxxxxxxxxx>  Thu, 22 Jun
2017 08:47:57 -0700

** Changed in: php-defaults (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1699659

Title:
  phpquery always returns 0

Status in php-defaults package in Ubuntu:
  Fix Released
Status in php-defaults source package in Xenial:
  Fix Released
Status in php-defaults source package in Yakkety:
  Fix Released
Status in php-defaults source package in Zesty:
  Fix Released
Status in php-defaults source package in Artful:
  Fix Released
Status in php-defaults package in Debian:
  Fix Released

Bug description:
  [Impact]

   * various PHP postinst uses php-defaults' scripts for determing what actions to perform.
   * The phpquery script has an error that does not propogate state correctly.

  [Test Case]

  [Regression Potential]

   * This is pure bug-fix backport from version 44 (in yakkety and on)
  to xenial. The regression potential is very low; most likely people
  were seeing the issue as reported in this bug and manually, e.g.,
  disabling modules again on every upgrade. This will actually avoid
  having to do that.

  ---

  In the course of diagnosing an issue with a PHP module (xdebug in this
  case) kept re-enabling itself during upgrades of libapache2-mod-
  php7.0, I found the following:

  1. libapache2-mod-php7.0 postscript sources /usr/lib/php/php-
  maintscript-helper from php-common to re-enable modules that have not
  been administratively disabled.

  2. php-maintscript-helper calls phpenmod based on the output and
  return codes of phpquery

  3. phpquery calls its own action() function, which initializes the
  $ret variable to 0

  4. phpquery action() calls into various other functions in the script,
  and sets the $ret variable based on their returns

  5. phpquery action() returns 0

  6. php-maintscript-helper correspondingly calls phpenmod on all
  available php modules for the apache2 SAPI

  Source link for xenial: https://git.launchpad.net/~usd-import-
  team/ubuntu/+source/php-defaults/tree/phpquery?h=ubuntu/xenial#n162

  the following addition to action() after the esac is necessary to
  bubble up the internal functions' returns:

  return $ret

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/php-defaults/+bug/1699659/+subscriptions