← Back to team overview

group.of.nepali.translators team mailing list archive

[Bug 1642812] Re: USB devices are not closed when error occurs

 

This bug was fixed in the package fwupd - 0.8.3-0ubuntu2

---------------
fwupd (0.8.3-0ubuntu2) xenial; urgency=medium

  * Fix systemd unit for what is actually supported in
    systemd 229 in xenial (LP: #1746114)
  * This bug also fixes issues with USB devices being closed (LP: #1642812)

 -- Mario Limonciello <mario.limonciello@xxxxxxxx>  Wed, 14 Feb 2018
14:32:41 -0500

** Changed in: fwupd (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1642812

Title:
  USB devices are not closed when error occurs

Status in fwupd package in Ubuntu:
  Fix Released
Status in fwupd source package in Xenial:
  Fix Released
Status in fwupd source package in Yakkety:
  Won't Fix
Status in fwupd source package in Zesty:
  Fix Released

Bug description:
  [Impact]

   * fwupd (used in Xenial) does not close USB device nodes when it fails to process the 
  devices.

   * The orphan (un-closed) device node will be kept until fwupd ends

   * The behavior will avoid the system to set the USB device as
  idle/suspend then the system cannot enter some power-saving mode (eg.
  S0ix)

  
  [Test Case]

   * make sure fwupd is not running by executing 'fwupdmgr get-devices'
     It will show devices information.

   * list the fds opened by fwupd
     $ sudo ls -l /proc/$(pgrep fwupd)/fd | grep usb
     If a system is not affected, it will output nothing.
     If the result shows one or more strings like /dev/bus/usb/[BUS]/[DEV]
     (BUS and DEV are numeric variables), that means the issue is existing.

  
  [Regression Potential] 

   * The fix only closes file descriptors of USB devices when errors
  happen and should not have regression there.

  
  [Original description]
    In fwupd, a few of USB devices are not closed when there are some failures of 
    operations. This issue will cause fwupd has some orphan USB nodes inside during fwupd is 
    running. A orphan USB node might introduce memory leak and block some runtime power 
    features as well.

    I proposed a upstream PR, and also put the link here.
    https://github.com/hughsie/fwupd/pull/73

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1642812/+subscriptions