group.of.nepali.translators team mailing list archive

[AaronMa <aaron.ma@xxxxxxxxxxxxx>]

** Tags removed: verification-needed-artful
** Tags added: verification-done-artful

** Changed in: hwe-next
       Status: New => Fix Released

** Changed in: linux (Ubuntu)
       Status: Incomplete => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1746002

Title:
  [SRU] TrackPoint: middle button doesn't work on TrackPoint-compatible
  device.

Status in HWE Next:
  Fix Released
Status in linux package in Ubuntu:
  Fix Released
Status in linux-oem package in Ubuntu:
  Invalid
Status in linux source package in Xenial:
  Invalid
Status in linux-oem source package in Xenial:
  Fix Released
Status in linux source package in Artful:
  Fix Committed
Status in linux-oem source package in Artful:
  Invalid

Bug description:
  Lenovo introduced 4 new TrackPoint compatible sticks those only
  support the minimum commands described in the spec, which has been
  used in the current Windows driver.

  Legacy TrackPoint: 0101 – 0E01

  ALPS: 0102 – FF02

  ELAN:0103 – FF03

  NXP: 0104 – FF04

  TrackPoint (ID: 01/02) report 0 button when reading the EXT_BUTTON
  command.

  Setting middle button enabled to make it work.

  Upstream patch:
  commit f5d07b9e98022d50720e38aa936fc11c67868ece
  Author: Aaron Ma <aaron.ma@xxxxxxxxxxxxx>
  Date:   Fri Jan 19 09:43:39 2018 -0800

      Input: trackpoint - force 3 buttons if 0 button is reported
      
      Lenovo introduced trackpoint compatible sticks with minimum PS/2 commands.
      They supposed to reply with 0x02, 0x03, or 0x04 in response to the
      "Read Extended ID" command, so we would know not to try certain extended
      commands. Unfortunately even some trackpoints reporting the original IBM
      version (0x01 firmware 0x0e) now respond with incorrect data to the "Get
      Extended Buttons" command:
      
       thinkpad_acpi: ThinkPad BIOS R0DET87W (1.87 ), EC unknown
       thinkpad_acpi: Lenovo ThinkPad E470, model 20H1004SGE
      
       psmouse serio2: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: 0/0
      
      Since there are no trackpoints without buttons, let's assume the trackpoint
      has 3 buttons when we get 0 response to the extended buttons query.
      
      Signed-off-by: Aaron Ma <aaron.ma@xxxxxxxxxxxxx>
      Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=196253
      Cc: stable@xxxxxxxxxxxxxxx
      Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

  
  SRU justification:
  ==============
  [Impact]
  Middle button on some TrackPoints with ThinkPad can't work on Ubuntu
  16.04. 
  Lenovo introduced 4 new TrackPoint compatible sticks those only support
  minimum commands, Sticks with ID 01/02 reported the external button 0,
  TrackPoint always have 3 buttons.

  [Fix]
  Set 3 buttons when 0 button is reported via PS/2 commands.

  [Test Case]
  Tested on Finn and E470, middle button works with this patch.

  [Regression Potential]
  No regression is expected.

  This patch had been send to stable kernel, so Bionic should have it
  with stable updates.

  Aaron Ma (1):
    Input: trackpoint - force 3 buttons if 0 button is reported

   drivers/input/mouse/trackpoint.c | 3 +++
   1 file changed, 3 insertions(+)

To manage notifications about this bug go to:
https://bugs.launchpad.net/hwe-next/+bug/1746002/+subscriptions