group.of.nepali.translators team mailing list archive

[Launchpad Bug Tracker <1738412@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package squid3 - 3.5.12-1ubuntu7.6

---------------
squid3 (3.5.12-1ubuntu7.6) xenial; urgency=medium

  * d/squid.rc: fix regexp for catching FATAL errors (LP: #1738412)
  * d/t/test-squid.py: in xenial,  initscript, apparmor profile, pidfile and
    process are named squid, not squid3. Get rid of the multiple distro
    logic since these tests will be only run on xenial.
  * d/t/control: drop uneeded dependency on python-unit.
  * d/t/squid: use a shorter shutdown timeout for the tests, so they
    run faster

 -- Andreas Hasenack <andreas@xxxxxxxxxxxxx>  Wed, 31 Oct 2018 09:22:14
-0300

** Changed in: squid3 (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1738412

Title:
  Init script fails test on reload/restart because of faulty regex

Status in squid3 package in Ubuntu:
  Fix Released
Status in squid3 source package in Xenial:
  Fix Released
Status in squid3 source package in Zesty:
  Won't Fix

Bug description:
  [Impact]
  The squid initscript has a guard against configuration mistakes that prevents the service from being disrupted if the current config has an invalid setting.

  This guard relies on the "squid -k parse" command which analyzes the
  configuration and, in the case of a fatal problem, outputs the string
  "FATAL: <reason>". The initscript parses that output to catch such
  errors before further action is taken.

  There is a mistake in the expression that is looked for, though:
  instead of "FATAL: ", the initscript is looking for "FATAL " (i.e., no
  ":"). The consequence is that actions that would reload or restart the
  service end up shutting the service down in the case of a
  configuration error.

  The change fixes the expression that is looked for, restoring the
  functionality of the guard.

  [Test Case]
  * install squid:
  sudo apt update && sudo apt install squid -y

  * confirm the reload action is quick to return and doesn't change the pid of squid, i.e., it's not restarted:
  ubuntu@xenial-squid-reload-syntax:~$ pidof squid
  2684
  ubuntu@xenial-squid-reload-syntax:~$ sudo service squid reload
  ubuntu@xenial-squid-reload-syntax:~$ pidof squid
  2684
  ubuntu@xenial-squid-reload-syntax:~$

  * add an invalid setting to the config file:
  echo "acl nonsense nonsense nonsense" | sudo tee -a /etc/squid/squid.conf

  * reload squid one more time:
  sudo service squid reload

  * After about 30s, squid should be dead and service squid status should show errors:
  ubuntu@xenial-squid-reload-syntax:~$ pidof squid
  ubuntu@xenial-squid-reload-syntax:~$

  ubuntu@xenial-squid-reload-syntax:~$ sudo service squid status
  ● squid.service - LSB: Squid HTTP Proxy version 3.x
  (...)
  Oct 29 19:56:26 xenial-squid-reload-syntax squid[2684]: Squid Parent: (squid-1) process 2881 started
  Oct 29 19:56:26 xenial-squid-reload-syntax squid[2684]: Squid Parent: (squid-1) process 2881 exited with status 1
  Oct 29 19:56:26 xenial-squid-reload-syntax squid[2684]: Squid Parent: (squid-1) process 2881 will not be restarted due to repeated, frequent failures
  Oct 29 19:56:26 xenial-squid-reload-syntax squid[2684]: Exiting due to repeated, frequent failures

  With the fixed package, a reload action (for example) will flag the
  error, and keep the service running:

  ubuntu@xenial-squid-reload-syntax:~$ pidof squid
  3801

  ubuntu@xenial-squid-reload-syntax:~$ sudo service squid reload
  Job for squid.service failed because the control process exited with error code. See "systemctl status squid.service" and "journalctl -xe" for details.

  ubuntu@xenial-squid-reload-syntax:~$ echo $?
  1

  ubuntu@xenial-squid-reload-syntax:~$ pidof squid
  3801

  And the status message will be much clearer:
  ubuntu@xenial-squid-reload-syntax:~$ sudo service squid status
  ● squid.service - LSB: Squid HTTP Proxy version 3.x
  ...
  Oct 29 20:13:26 xenial-squid-reload-syntax systemd[1]: Reloading LSB: Squid HTTP Proxy version 3.x.
  Oct 29 20:13:26 xenial-squid-reload-syntax squid[3920]:  * FATAL: Invalid ACL type 'nonsense'
  Oct 29 20:13:26 xenial-squid-reload-syntax squid[3920]: FATAL: Bungled /etc/squid/squid.conf line 7897: acl nonsense nonsense nonsense
  Oct 29 20:13:26 xenial-squid-reload-syntax systemd[1]: squid.service: Control process exited, code=exited status=3
  Oct 29 20:13:26 xenial-squid-reload-syntax systemd[1]: Reload failed for LSB: Squid HTTP Proxy version 3.x.

  [Regression Potential]
  This changes not only the reload action, but also start and consequently restart. The fix makes an existing safety net around those actions actually work, instead of being ignored.
  Due to the lack of an explicit restart action in systemd, however, the restart guard in the SysV initscript doesn't take effect. If there is a bad config, and squid is restarted, the service will be in a stopped state at the end:
  - stop will succeed
  - start will fail: service remains stopped

  There is an upstream bug about it:
  https://github.com/systemd/systemd/issues/2175

  This is not a regression, however, as it's the same behavior as
  before, but it will have an interesting consequence in package
  upgrades.

  With the old package, admins upgrading squid to a newer version while
  having a syntax error in their configs will end up with a stopped
  service, but no notification of that, since the restart postinst
  action will exit 0.

  With the new package, the same scenario will trigger an upgrade failure like this:
  dpkg: error processing package squid (--configure):
   subprocess installed post-installation script returned error exit status 1
  Processing triggers for systemd (229-4ubuntu21.5) ...
  Processing triggers for ureadahead (0.100.0-19) ...
  Errors were encountered while processing:
   squid
  E: Sub-process /usr/bin/dpkg returned an error code (1)

  So the end result is the same as before, in the sense that squid won't
  be running after the upgrade, but now it will be clear. I expect this
  can trigger some apport bug reports, though.

  [Other Info]
  Not at this time.

  [Original Description]

  This is a very serious issue that got fixed upstream in:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800341

  It is also logged in the Ubuntu changelog as fixed in:

  squid3 (3.5.12-1) unstable; urgency=medium
    [ Mathieu Parent ]
    * Fix FATAL parsing before start/reload/restart (Closes: #800341)

  But is in fact not fixed.
  When I look in the source package I find two init scripts:
  squid3.rc and squid.rc. squid3.rc has the patch while squid.rc does not.

  The one being included in the package and deployed is the one that
  does not have the fix.

  I'm including a patch to fix this issue.
  Please push this out ASAP.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1738412/+subscriptions