group.of.nepali.translators team mailing list archive
-
group.of.nepali.translators team
-
Mailing list archive
-
Message #28468
[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
This bug was fixed in the package fwts - 18.09.00-0ubuntu2
---------------
fwts (18.09.00-0ubuntu2) cosmic; urgency=medium
[Colin Ian King]
* efi_runtime: fix access_ok build issues on 5.0 kernels (LP: #1813059)
- add Linux 5.0 compat fix to access_ok to fix dkms build issue
-- Colin Ian King <colin.king@xxxxxxxxxxxxx> Thu, 24 Jan 2019 09:25:11
+0000
** Changed in: fwts (Ubuntu Cosmic)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1813059
Title:
fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
Status in fwts package in Ubuntu:
Fix Released
Status in fwts source package in Xenial:
Fix Committed
Status in fwts source package in Bionic:
Fix Committed
Status in fwts source package in Cosmic:
Fix Released
Status in fwts source package in Disco:
Fix Released
Bug description:
== SRU Justification, Xenial, Bionic, Cosmic ==
The DKMS kernel module fails to build if new 5.0 kernels are used
because of an API change in access_ok().
== Fix ==
Add a kernel version detection and a macro compat fix to paper over
the API differences between the two version:
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 0, 0)
+#define ACCESS_OK(type, addr, size) access_ok(addr, size)
+#else
+#define ACCESS_OK(type, addr, size) access_ok(type, addr, size)
+#endif
and use ACCESS_OK instead of access_ok.
== Regression Potential ==
Minimal - this build time change will select the appropriate API, so
the final resultant compiled code will be identical to the original
before the patch for current kernels, and only different for 5.0+
kernels.
== How To test ==
Install fwts with a 5.0 kernel. Without the fix the dkms build of the
efi driver will fail. With the fix it will succeed.
--------------------------------------------------------------------------
Testing failed on:
amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/amd64/f/fwts/20190123_163310_2b561@/log.gz
arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/arm64/f/fwts/20190123_164249_2b561@/log.gz
armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/armhf/f/fwts/20190123_164402_2b561@/log.gz
i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/i386/f/fwts/20190123_163518_2b561@/log.gz
ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/ppc64el/f/fwts/20190123_163508_2b561@/log.gz
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions