group.of.nepali.translators team mailing list archive

["Heitor R. Alves de Siqueira" <1819046@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

[Impact]
Systemd Unit file doesn't read any settings by default

[Description]
The unit file shipped with the Xenial pacemaker package tries to read environment settings from /etc/sysconfig/ instead of /etc/default/. The result is that settings defined in /etc/default/pacemaker are not effective.
Since the /etc/default/pacemaker file is created with default values when the pacemaker package is installed, we should source that in the systemd unit file.

[Test Case]
1) Deploy a Xenial container:
    $ lxc launch ubuntu:xenial pacemaker
2) Update container and install pacemaker:
    root@pacemaker:~# apt update && apt install pacemaker -y
3) Check the systemd unit file for the "EnvironmentFile" option:
    root@pacemaker:~# systemctl cat pacemaker | grep EnvironmentFile
    EnvironmentFile=-/etc/sysconfig/pacemaker
    EnvironmentFile=-/etc/sysconfig/sbd

[Regression Potential]
The regression potential for this should be very low, since the configuration file is already being created by default and other systemd unit files are using the /etc/default config. In case the file doesn't exist or the user removed it, the "-" prefix will gracefully ignore the missing file according to the systemd.exec manual [0].
Nonetheless, the new package will be tested with autopkgtests and the fix will be validated in a reproduction environment.

[0] https://www.freedesktop.org/software/systemd/man/systemd.exec.html

** Affects: pacemaker (Ubuntu)
     Importance: Undecided
     Assignee: Heitor R. Alves de Siqueira (halves)
         Status: Fix Released

** Affects: pacemaker (Ubuntu Xenial)
     Importance: Undecided
     Assignee: Heitor R. Alves de Siqueira (halves)
         Status: Confirmed


** Tags: sts

** Also affects: pacemaker (Ubuntu Xenial)
   Importance: Undecided
       Status: New

** Changed in: pacemaker (Ubuntu Xenial)
       Status: New => Confirmed

** Changed in: pacemaker (Ubuntu)
       Status: Confirmed => Fix Released

** Changed in: pacemaker (Ubuntu Xenial)
     Assignee: (unassigned) => Heitor R. Alves de Siqueira (halves)

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1819046

Title:
  Systemd unit file reads settings from wrong path

Status in pacemaker package in Ubuntu:
  Fix Released
Status in pacemaker source package in Xenial:
  Confirmed

Bug description:
  [Impact]
  Systemd Unit file doesn't read any settings by default

  [Description]
  The unit file shipped with the Xenial pacemaker package tries to read environment settings from /etc/sysconfig/ instead of /etc/default/. The result is that settings defined in /etc/default/pacemaker are not effective.
  Since the /etc/default/pacemaker file is created with default values when the pacemaker package is installed, we should source that in the systemd unit file.

  [Test Case]
  1) Deploy a Xenial container:
      $ lxc launch ubuntu:xenial pacemaker
  2) Update container and install pacemaker:
      root@pacemaker:~# apt update && apt install pacemaker -y
  3) Check the systemd unit file for the "EnvironmentFile" option:
      root@pacemaker:~# systemctl cat pacemaker | grep EnvironmentFile
      EnvironmentFile=-/etc/sysconfig/pacemaker
      EnvironmentFile=-/etc/sysconfig/sbd

  [Regression Potential]
  The regression potential for this should be very low, since the configuration file is already being created by default and other systemd unit files are using the /etc/default config. In case the file doesn't exist or the user removed it, the "-" prefix will gracefully ignore the missing file according to the systemd.exec manual [0].
  Nonetheless, the new package will be tested with autopkgtests and the fix will be validated in a reproduction environment.

  [0] https://www.freedesktop.org/software/systemd/man/systemd.exec.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pacemaker/+bug/1819046/+subscriptions