← Back to team overview

group.of.nepali.translators team mailing list archive

[Bug 1818150] Re: Hibinit-agent configures GRUB referring to root partition as resume=/dev/root

 

Tested on Cosmic, Bionic and Xenial with the latest version in
-proposed:

ubuntu@ip-172-31-11-18:~$ dpkg -l ec2-hibinit-agent | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name              Version                Architecture Description
+++-=================-======================-============-=================================
ii  ec2-hibinit-agent 1.0.0-0ubuntu4~18.10.0 all          Amazon EC2 hibernation agent
ubuntu@ip-172-31-11-18:~$ grep -m 1 root= /boot/grub/grub.cfg
	  linux	/boot/vmlinuz-4.18.0-1011-aws root=PARTUUID=71d081c0-01 ro  console=tty1 console=ttyS0 nvme_core.io_timeout=4294967295 no_console_suspend=1 resume_offset=245760 resume=PARTUUID=71d081c0-01


ubuntu@ip-172-31-7-41:~$  dpkg -l ec2-hibinit-agent | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name              Version                Architecture Description
+++-=================-======================-============-=================================
ii  ec2-hibinit-agent 1.0.0-0ubuntu4~18.04.0 all          Amazon EC2 hibernation agent
ubuntu@ip-172-31-7-41:~$ grep -m 1 root= /boot/grub/grub.cfg
        linux	/boot/vmlinuz-4.15.0-1033-aws root=UUID=b5361850-7320-445b-b1c9-a8b294830484 ro  console=tty1 console=ttyS0 nvme.io_timeout=4294967295 no_console_suspend=1 resume_offset=235520 resume=/dev/xvda1


ubuntu@ip-172-31-12-48:~$ dpkg -l ec2-hibinit-agent | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name              Version                Architecture Description
+++-=================-======================-============-=================================
ii  ec2-hibinit-agent 1.0.0-0ubuntu4~16.04.0 all          Amazon EC2 hibernation agent
ubuntu@ip-172-31-12-48:~$ grep -m 1 root= /boot/grub/grub.cfg
        linux	/boot/vmlinuz-4.4.0-1077-aws root=UUID=7d8f7a6c-6fdc-4cfe-a376-95b51a59f117 ro  console=tty1 console=ttyS0 nvme.io_timeout=4294967295 nvme_core.io_timeout=4294967295 no_console_suspend=1 resume_offset=346112 resume=/dev/xvda1


** Tags removed: verification-needed verification-needed-bionic verification-needed-cosmic verification-needed-trusty verification-needed-xenial
** Tags added: verification-done verification-done-bionic verification-done-cosmic verification-done-xenial

** Changed in: ec2-hibinit-agent (Ubuntu Trusty)
       Status: Fix Committed => Won't Fix

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1818150

Title:
  Hibinit-agent configures GRUB referring to root partition as
  resume=/dev/root

Status in ec2-hibinit-agent package in Ubuntu:
  Fix Released
Status in ec2-hibinit-agent source package in Trusty:
  Won't Fix
Status in ec2-hibinit-agent source package in Xenial:
  Fix Committed
Status in ec2-hibinit-agent source package in Bionic:
  Fix Committed
Status in ec2-hibinit-agent source package in Cosmic:
  Fix Committed

Bug description:
  [Impact]

   * The kernel can't find /dev/root when booting initramfsless thus can't resume from hibernation
   * The fix sets resume=... to the same identifier passed as root=... on the kernel command when the swap file is found to be on /dev/root.

  [Test Case]

   * (Install and) start hibinit-agent on an EC2 instance supporting hibernation, then when it started successfully verify the grub configuration:
  $ grep -m 1 root= /boot/grub/grub.cfg
     linux	/boot/vmlinuz-4.18.0-1008-aws root=PARTUUID=6b4ea835-01 ro  console=tty1 console=ttyS0 nvme.io_timeout=4294967295 no_console_suspend=1 resume_offset=438272 resume=PARTUUID=6b4ea835-01

    resume=... must not refer to /dev/root with the default
  configuration, but to a block device known to the kernel without using
  initramfs.

  [Regression Potential]

   * Hibinit-agent may parse the grub configuration file incorrectly and
  set a wrong partition to resume from. Since the fix is quite small and
  the number of variants of grub configurations is also small this
  regression is unlikely.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1818150/+subscriptions