group.of.nepali.translators team mailing list archive

[Eric Desrochers <eric.desrochers@xxxxxxxxxxxxx>]

Public bug reported:

[IMPACT]

Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script, 
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.

While there is no 'real' impact, I think it make total sense for a
systemd Xenial system, to use the systemctl approach for logrotation

[TEST CASE]

* On a Xenial active systemd system:

Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate

Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf

Check if logs rotation happeneded in /var/log.
# ls -altr /var/log

* On a Xenial active upstart system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate

Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf

Check if logs rotation happeneded in /var/log.
# ls -altr /var/log


[POTENTIAL REGRESSION

* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. 
  Meaning no behaviour change for users who decided not to use systemd on their Xenial system.

  /usr/lib/rsyslog/rsyslog-rotate:
  1) Check if existence of systemd, if yes; systemctl kill -s HUP rsyslog.service
  2) Check if existence of systemd, if no ; invoke-rc.d rsyslog rotate > /dev/null

[OTHER INFO]

* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e

* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1

* rmadison:
=>  rsyslog | 8.16.0-1ubuntu3  | xenial           
    rsyslog | 8.32.0-1ubuntu4  | bionic           
    rsyslog | 8.32.0-1ubuntu5  | cosmic           
    rsyslog | 8.32.0-1ubuntu7  | disco

** Affects: rsyslog (Ubuntu)
     Importance: Undecided
         Status: Fix Released

** Affects: rsyslog (Ubuntu Xenial)
     Importance: Medium
     Assignee: Eric Desrochers (slashd)
         Status: In Progress


** Tags: sts

** Changed in: rsyslog (Ubuntu)
       Status: New => Fix Released

** Also affects: rsyslog (Ubuntu Xenial)
   Importance: Undecided
       Status: New

** Tags added: sts

** Changed in: rsyslog (Ubuntu Xenial)
       Status: New => In Progress

** Changed in: rsyslog (Ubuntu Xenial)
   Importance: Undecided => Medium

** Changed in: rsyslog (Ubuntu Xenial)
     Assignee: (unassigned) => Eric Desrochers (slashd)

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1821582

Title:
  Don't rely on SysV init script in logrotate config

Status in rsyslog package in Ubuntu:
  Fix Released
Status in rsyslog source package in Xenial:
  In Progress

Bug description:
  [IMPACT]

  Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script, 
  taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.

  While there is no 'real' impact, I think it make total sense for a
  systemd Xenial system, to use the systemctl approach for logrotation

  [TEST CASE]

  * On a Xenial active systemd system:

  Determine the script pick the right decision approach.
  # bash -vx /usr/lib/rsyslog/rsyslog-rotate

  Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
  # logrotate -vdf /etc/logrotate.conf

  Check if logs rotation happeneded in /var/log.
  # ls -altr /var/log

  * On a Xenial active upstart system:
  Determine the script pick the right decision approach.
  # bash -vx /usr/lib/rsyslog/rsyslog-rotate

  Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
  # logrotate -vdf /etc/logrotate.conf

  Check if logs rotation happeneded in /var/log.
  # ls -altr /var/log

  
  [POTENTIAL REGRESSION

  * None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. 
    Meaning no behaviour change for users who decided not to use systemd on their Xenial system.

    /usr/lib/rsyslog/rsyslog-rotate:
    1) Check if existence of systemd, if yes; systemctl kill -s HUP rsyslog.service
    2) Check if existence of systemd, if no ; invoke-rc.d rsyslog rotate > /dev/null

  [OTHER INFO]

  * Salsa rsyslog repository:
  https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e

  * First introduced:
  git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
  debian/8.27.0-4~1

  * rmadison:
  =>  rsyslog | 8.16.0-1ubuntu3  | xenial           
      rsyslog | 8.32.0-1ubuntu4  | bionic           
      rsyslog | 8.32.0-1ubuntu5  | cosmic           
      rsyslog | 8.32.0-1ubuntu7  | disco

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rsyslog/+bug/1821582/+subscriptions