← Back to team overview

group.of.nepali.translators team mailing list archive

[Bug 1790788] Re: Customize 'crashkernel' parameter is not properly working

 

This bug was fixed in the package makedumpfile -
1:1.6.5-1ubuntu1~18.10.1

---------------
makedumpfile (1:1.6.5-1ubuntu1~18.10.1) cosmic; urgency=low

  * Backport back to cosmic. (LP: #1655280) (LP: #1790788)

makedumpfile (1:1.6.5-1ubuntu1) disco; urgency=low

  [ Ubuntu Merge-o-Matic ]
  * Merge from Debian unstable.  Remaining changes:
    - Bump amd64 crashkernel from 384M-:128M to 512M-:192M.

  [ Thadeu Lima de Souza Cascardo ]
  * Use a different service for vmcore dump. (LP: #1811692)

makedumpfile (1:1.6.5-1) unstable; urgency=medium

  * Update to new upstream version 1.6.5.
  * debian: remove debian/source/local-options
  * [i18n] Move PT debconf translation (Closes: #910465)

makedumpfile (1:1.6.4-3) unstable; urgency=medium

  * Reload kdump after memory/CPU hotplug. (LP: #1655280)
  * Fix adding crashkernel to zipl.conf when no quotation mark is used.
    (LP: #1790788)

 -- Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxx>  Thu, 07 Feb
2019 09:22:23 -0200

** Changed in: makedumpfile (Ubuntu Cosmic)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1790788

Title:
  Customize 'crashkernel' parameter is not properly working

Status in Ubuntu on IBM z Systems:
  In Progress
Status in makedumpfile package in Ubuntu:
  Fix Released
Status in makedumpfile source package in Xenial:
  New
Status in makedumpfile source package in Bionic:
  Fix Committed
Status in makedumpfile source package in Cosmic:
  Fix Released
Status in makedumpfile source package in Disco:
  Fix Released

Bug description:
  SRU Justification:
  ------------------

  [Impact]

   * While installing makedumpfile the "crashkernel=" argument is not
  properly set, hence dump is not triggered on reboot.

   * Means the triggering of dumpfiles is currently not possible using
  makedumpfile.

   * Dumpfiles are obviously only needed in rare cases, but if they are
  needed (e.g. in production environments) the situation is usually
  critical.

   * Hence fixing this is needed to allow post-mortem analysis of a
  dumps.

   * The provided shell code snippet provides a fixed sed statement that
  makes sure that the kernel parameter is propoerly set.

  [Test Case]

   * Create and boot a s390x (KVM virtual) machine

   * Install kdump-tools and makedumpfile
     Select 'yes' on question 'Should kdump-tools be enabled by default?' during installation

   * [ Reboot system ]

   * Look for crashkernel line in zipl boot-loader
     grep crashkernel /etc/zipl.conf
     crashkernel line is missing in case this bug still exists
     one or more lines like this should be given:
     parameters = root=UUID=5ed8f208-adce-4fad-b1a6-feb5e8732d89 crashkernel=196M

   * One may further trigger a crash (for a full positiv test)
     sudo -s
     sysctl -w kernel.sysrq=1
     echo c > /proc/sysrq-trigger
     (in case this bug still exists the system will not come up again - check console in parallel)
     Finally dump files should be visible in /var/crash

  [Regression Potential]

   * The regression potential is very low, since:

   * it's limited to the zipl boot loader configuration file only
     and this means again it's on the s390x platform only (IBM Z)

   * kdump-tools and makedumpfile are not installed by default and only used in debug situations
     hence only system where the package(s) got manually installed get updated

   * The function is today broken anyway, hence it can actually only get
  better

   * I successfully verified this in disco.
  _________________________

  Trying to use crashdump especially in a KVM machine.
  Installation looks fine and the reboot is triggered.
  But it does not work because the kernel does not have a 'crashkernel=' parameter.
  Nothing in /proc/cmdline:
  $ cat /proc/cmdline
  root=LABEL=cloudimg-rootfs

  Issue seems to be in adding the crashkernel line in this snippet:
  # Customize crashkernel= value according to architecture
  ARCH="$(arch)"
  DEF_PRESET="384M-:128M"
  case "$ARCH" in
     s390x)
        HAS_CRASHKERNEL="$(grep crashkernel /etc/zipl.conf)" || true
        if test -z "$HAS_CRASHKERNEL"; then
           sed -i "/parameters/{s|\"$| crashkernel=${DEF_PRESET}\"|}" /etc/zipl.conf
           zipl
        fi
           CIO_IGNORE="$(cio_ignore -u -k)"
           sed -i "s/\#KDUMP_CMDLINE_APPEND/KDUMP_CMDLINE_APPEND/" $INITCONFFILE
           sed -i "/KDUMP_CMDLINE_APPEND/{s|\"$| ${CIO_IGNORE}\"|}" $INITCONFFILE
      ;;
  esac

  (especially 1st sed stmt)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1790788/+subscriptions