group.of.nepali.translators team mailing list archive

[Launchpad Bug Tracker <1838533@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package linux-azure - 4.15.0-1055.60

---------------
linux-azure (4.15.0-1055.60) xenial; urgency=medium

  * xenial/linux-azure: 4.15.0-1055.60 -proposed tracker (LP: #1839287)

  * Packaging resync (LP: #1786013)
    - [Packaging] update helper scripts

  [ Ubuntu: 4.15.0-58.64 ]

  * unable to handle kernel NULL pointer dereference at 000000000000002c (IP:
    iget5_locked+0x9e/0x1f0) (LP: #1838982)
    - Revert "ovl: set I_CREATING on inode being created"
    - Revert "new primitive: discard_new_inode()"

 -- Marcelo Henrique Cerri <marcelo.cerri@xxxxxxxxxxxxx>  Thu, 08 Aug
2019 14:52:35 -0300

** Changed in: linux-azure (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1838533

Title:
  Bionic linux 4.15.0-56.62 fails to build with CONFIG_NVM disabled

Status in linux package in Ubuntu:
  Invalid
Status in linux-azure package in Ubuntu:
  Invalid
Status in linux source package in Xenial:
  Invalid
Status in linux-azure source package in Xenial:
  Fix Released
Status in linux source package in Bionic:
  Fix Committed
Status in linux-azure source package in Bionic:
  Invalid

Bug description:
  [Impact]

  When compiling bionic linux 4.15.0-56.62 with CONFIG_NVM disabled, it
  fails with:

  make[5]: *** [drivers/nvme/host/core.o] Error 1
  make[5]: *** Waiting for unfinished jobs....
  In file included from /tmp/kernel-kleber-57dc2e6-NQe1/build/drivers/nvme/host/multipath.c:15:0:
  /tmp/kernel-kleber-57dc2e6-NQe1/build/drivers/nvme/host/nvme.h: In function 'nvme_nvm_register_sysfs':
  /tmp/kernel-kleber-57dc2e6-NQe1/build/drivers/nvme/host/nvme.h:502:6: error: 'ctrl' undeclared (first use in this function)
    if (ctrl->subsys->cmic & (1 << 3))
        ^
  /tmp/kernel-kleber-57dc2e6-NQe1/build/drivers/nvme/host/nvme.h:502:6: note: each undeclared identifier is reported only once for each function it appears in

  [Fix]
  The culprit seems to be this patch:

  commit 993f70b886c0062fb5ec7c3c556d074bb3380b9d
  Author: Christoph Hellwig <hch@xxxxxx>
  Date:   Tue Nov 20 16:57:54 2018 +0100

      nvme: warn when finding multi-port subsystems without multipathing
  enabled

      BugLink: https://bugs.launchpad.net/bugs/1837161

      [ Upstream commit 14a1336e6fff47dd1028b484d6c802105c58e2ee ]
  [...]
  --- a/drivers/nvme/host/nvme.h
  +++ b/drivers/nvme/host/nvme.h
  @@ -499,6 +499,9 @@ static inline int nvme_nvm_register(struct nvme_ns *ns, char *disk_name,
   static inline void nvme_nvm_unregister(struct nvme_ns *ns) {};
   static inline int nvme_nvm_register_sysfs(struct nvme_ns *ns)
   {
  +       if (ctrl->subsys->cmic & (1 << 3))
  +               dev_warn(ctrl->device,
  +"Please enable CONFIG_NVME_MULTIPATH for full support of multi-port devices.\n");
          return 0;
   }

  which is adding the new lines to a different function than the
  original upstream commit:

  --- a/drivers/nvme/host/nvme.h
  +++ b/drivers/nvme/host/nvme.h
  @@ -531,6 +531,9 @@ static inline void nvme_mpath_check_last_path(struct nvme_ns *ns)
   static inline int nvme_mpath_init(struct nvme_ctrl *ctrl,
                  struct nvme_id_ctrl *id)
   {
  +       if (ctrl->subsys->cmic & (1 << 3))
  +               dev_warn(ctrl->device,
  +"Please enable CONFIG_NVME_MULTIPATH for full support of multi-port devices.\n");
          return 0;
   }

  This patch was probably wrongly backported for bug #1837161 from
  linux-4.19.y stable and not needed since bionic/linux lacks commit
  0d0b660f214d (nvme: add ANA support) which introduced
  nvme_mpath_init(). The fix is to revert this patch.

  [Test Case]

  Disabled kernel config CONFIG_NVM and compile the kernel.

  [Regression Potential]

  Low. The patch was wrongly backported and can be safely reverted.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1838533/+subscriptions