group.of.nepali.translators team mailing list archive

[Launchpad Bug Tracker <1589289@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package util-linux - 2.27.1-6ubuntu3.8

---------------
util-linux (2.27.1-6ubuntu3.8) xenial; urgency=medium

  * d/p/prevent-fstrim-inside-container.patch:
    - Prevent fstrim to run inside a container environment.
    (LP: #1589289)

  * d/fstrim-all.cron: Prevent cron.weekly to fstrim if inside a
    container.

 -- Eric Desrochers <eric.desrochers@xxxxxxxxxxxxx>  Thu, 22 Aug 2019
23:56:21 +0000

** Changed in: util-linux (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1589289

Title:
  fstrim: cannot open /dev/.lxd-mounts: Permission denied

Status in util-linux package in Ubuntu:
  Fix Released
Status in util-linux source package in Xenial:
  Fix Released
Status in util-linux source package in Bionic:
  Fix Released
Status in util-linux source package in Disco:
  Fix Released
Status in util-linux package in Debian:
  New

Bug description:
  [Impact]
  fstrim weekly cronjob output in an unprivileged LXD container:

  /etc/cron.weekly/fstrim:
  fstrim: cannot open /dev/.lxd-mounts: Permission denied
  fstrim: /dev/fuse: not a directory
  fstrim: /dev/lxd: FITRIM ioctl failed: Operation not permitted

  There is a github issue:

  https://github.com/lxc/lxd/issues/2030

  The outcome is that it's purely an fstrim misbehaviour, it could be
  smarter.

  Stephane Graber comment:

  As all of this is handled by the kernel, there isn't anything we can
  do about it in LXD.

  I think fstrim should be made slightly more clever:

  * Don't run on bind-mounts (you can detect bind-mounts by parsing /proc/self/mountinfo instead of /proc/mounts)
  * Maybe not be as noisy on expected errors like EACCES, EPERM and ENOENT, only log actual failures which would likely be EINVAL or memory related errors.

  ProblemType: Bug
  DistroRelease: Ubuntu 16.04
  Package: util-linux 2.27.1-6ubuntu3
  ProcVersionSignature: Ubuntu 4.4.0-21.37-generic 4.4.6
  Uname: Linux 4.4.0-21-generic x86_64
  ApportVersion: 2.20.1-0ubuntu2.1
  Architecture: amd64
  Date: Sun Jun  5 19:49:04 2016
  ProcEnviron:
   LANGUAGE=en_US:en
   TERM=xterm
   PATH=(custom, no user)
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: util-linux
  UpgradeStatus: No upgrade log present (probably fresh install)

  [Test Case]
  * Ubuntu lxd container
  * Wait for the scheduled fstrim run (X: cronjob, B and late: systemd timer)
  * fstrim will run and report errors "Operation not permitted" "Permission denied", ...

  Container shouldn't run fstrim, it should only be run at host level.

  [Potential Regression]

  None, the change will only block fstrim to be automatically run at
  scheduled time. One can still run fstrim on a container manually, even
  if there is no purpose of doing that.

  Xenial uses the cronjob approach /etc/cron.weekly/fstrim
  Bionic and late switched to a systemd timer.

  2 differents fixes (one for X, and one for B and late) will be needed,
  but they'll do same thing, which prevent fstrim to automatically run
  if inside a container both fixes using systemd-virt-detect.

  [Other Informations]

  * The systemd timer change upstream PR:
  https://github.com/karelzak/util-linux/pull/841
  https://github.com/karelzak/util-linux/commit/0280d31a2bd6292acd9a4b86d0f6b5feb275a618

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1589289/+subscriptions