group.of.nepali.translators team mailing list archive

[Steve Langasek <1794999@xxxxxxxxxxxxxxxxxx>]

The Precise Pangolin has reached end of life, so this bug will not be
fixed for that release

** Changed in: pam-python (Ubuntu Precise)
       Status: New => Won't Fix

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1794999

Title:
  wrong null pointer check

Status in pam-python package in Ubuntu:
  Confirmed
Status in pam-python source package in Precise:
  Won't Fix
Status in pam-python source package in Trusty:
  New
Status in pam-python source package in Xenial:
  Fix Released
Status in pam-python source package in Bionic:
  Fix Released

Bug description:
  Building pam-python from source on Ubuntu bionic fails with this error
  message:

  make[2]: Entering directory '/tmp/source_copy/pam-python/src'
  gcc -O0 -Wall -Wextra -Wundef -Wshadow -Wpointer-arith -Wbad-function-cast -Wsign-compare -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Werror -g -o ctest ctest.c -lpam
  CFLAGS="-Wall -Wextra -Wundef -Wshadow -Wpointer-arith -Wbad-function-cast -Wsign-compare -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Werror -I/usr/local/lib/ " ./setup.py build
  running build
  running build_ext
  building 'pam_python' extension
  creating build
  creating build/temp.linux-x86_64-2.7
  x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wall -Wextra -Wundef -Wshadow -Wpointer-arith -Wbad-function-cast -Wsign-compare -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Werror -I/usr/local/lib/ -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -DLIBPYTHON_SO="libpython2.7.so.1.0" -I/usr/include/python2.7 -c pam_python.c -o build/temp.linux-x86_64-2.7/pam_python.o
  pam_python.c: In function 'call_handler':
  pam_python.c:2229:19: error: argument 1 null where non-null expected [-Werror=nonnull]
     if (dot != 0 || strcmp(dot, ".py") == 0)
                     ^~~~~~~~~~~~~~~~~~
  In file included from /usr/include/security/_pam_macros.h:13:0,
                   from pam_python.c:33:
  /usr/include/string.h:136:12: note: in a call to function 'strcmp' declared here
   extern int strcmp (const char *__s1, const char *__s2)
              ^~~~~~
  cc1: all warnings being treated as errors
  error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
  make[2]: *** [pam_python.so] Error 1
  Makefile:9: recipe for target 'pam_python.so' failed
  make[2]: Leaving directory '/tmp/source_copy/pam-python/src'
  make[1]: *** [lib] Error 2
  make: *** [build-arch] Error 2
  Makefile:6: recipe for target 'lib' failed
  make[1]: Leaving directory '/tmp/source_copy/pam-python'
  debian/rules:38: recipe for target 'build-arch' failed
  dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2


  The null pointer check condition is wrong in pam_python.c:2229

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pam-python/+bug/1794999/+subscriptions