group.of.nepali.translators team mailing list archive

[Miriam España Acebal <1437359@xxxxxxxxxxxxxxxxxx>]

** Changed in: corosync (Ubuntu Bionic)
       Status: In Progress => Won't Fix

** Changed in: corosync (Ubuntu Bionic)
   Importance: Low => Wishlist

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1437359

Title:
  A PIDFILE is double-defined for the corosync-notifyd init script

Status in corosync package in Ubuntu:
  Fix Released
Status in corosync source package in Trusty:
  Won't Fix
Status in corosync source package in Xenial:
  Won't Fix
Status in corosync source package in Bionic:
  Won't Fix
Status in corosync source package in Disco:
  Won't Fix
Status in corosync source package in Eoan:
  Won't Fix
Status in corosync source package in Focal:
  Fix Released

Bug description:
  [SRU]

  [Impact]

   Users that use the sysv services provided by corosync-notifyd and corosync packages
   may find a corosync-notifyd service's misfunction because it uses the pid file
   created by corosync service.

  [Test Plan]

   In a new VM with bionic (specifically for this testing):

   #Disabling systemd (this will lead you to a non-usable system at the end for other things, but
   this is only for testing purposes of this bug -systemctl disable <service> didn't work-):
   sudo apt remove --purge systemd

   #Install corosync and corosync-notifyd:
   sudo apt install corosync corosync-notifyd

   #check versions (optional):
   ubuntu@bionic-corosync-sysv:~/Builds$ dpkg -l | grep coro
   ii  corosync                         2.4.3-0ubuntu1.2                          amd64        cluster engine daemon and utilities
   ii  corosync-notifyd                 2.4.3-0ubuntu1.2                          amd64        cluster engine notification daemon
   ii  libcorosync-common4:amd64        2.4.3-0ubuntu1.2                          amd64        cluster engine common library

   #Start notifyd service:
   ubuntu@bionic-corosync-sysv:/etc/init.d$ sudo ./corosync-notifyd start
   * Starting corosync notifying daemon corosync-notifyd                              [ OK ]

   #Check that pid filename is not correct:
   ubuntu@bionic-corosync-sysv:/etc/init.d$ l /var/run/coro*
   /var/run/corosync.pid

   #stop de service, check pid file is gone and install  new version:
   ubuntu@bionic-corosync-sysv:/etc/init.d$ sudo ./corosync-notifyd stop
   * Stopping corosync notifying daemon corosync-notifyd                              [ OK ]
   ubuntu@bionic-corosync-sysv:/etc/init.d$ l /var/run/coro*
   ls: cannot access '/var/run/coro*': No such file or directory
   ubuntu@bionic-corosync-sysv:/etc/init.d$ sudo dpkg -i /home/ubuntu/Builds/corosync-notifyd_2.4.3-0ubuntu1.3_amd64.deb
   (Reading database ... 59514 files and directories currently installed.)
   Preparing to unpack .../corosync-notifyd_2.4.3-0ubuntu1.3_amd64.deb ...
   Unpacking corosync-notifyd (2.4.3-0ubuntu1.3) over (2.4.3-0ubuntu1.2) ...
   /var/lib/dpkg/info/corosync-notifyd.postrm: 12: /var/lib/dpkg/info/corosync-notifyd.postrm: systemctl: not found
   Setting up corosync-notifyd (2.4.3-0ubuntu1.3) ...
   Installing new version of config file /etc/init.d/corosync-notifyd ...
   Can't exec "systemctl": No such file or directory at /usr/sbin/update-rc.d line 93.
   /usr/sbin/invoke-rc.d: 282: /usr/sbin/invoke-rc.d: systemctl: not found
   invoke-rc.d: could not determine current runlevel
   invoke-rc.d: WARNING: No init system and policy-rc.d missing! Defaulting to block.
   Processing triggers for dbus (1.12.2-1ubuntu1.2) ...
   Processing triggers for ureadahead (0.100.0-21) ...
   Processing triggers for man-db (2.8.3-2ubuntu0.1) ...

   #Start notifyd service
   ubuntu@bionic-corosync-sysv:/etc/init.d$ sudo ./corosync-notifyd start
   * Starting corosync notifying daemon corosync-notifyd                              [ OK ]

   #Check pid-filename is now the same as daemon's name (corosync-notifyd):
   ubuntu@bionic-corosync-sysv:/etc/init.d$ l /var/run/coro*
   /var/run/corosync-notifyd.pid

  [Where problems could occur]

   The fix is cherrypicked from the Focal's solution, only affects corosync-notifyd and
   corosync services. No other services depend on this pid files. No systemd services affected.

  [Other Info]

   This solution follows the example of the same bug fixed in Focal at https://bugs.launchpad.net/ubuntu/+source/corosync/+bug/1869622 ,
   alongside bug https://bugs.launchpad.net/ubuntu/+source/corosync/+bug/1677684 (in progress to be SRU processed also for Bionic).

   Although the number of users affected by this is a minority, I decided to fix this
   in concordance with that this issue is fixed in Focal and it's a copy/paste error
   easy to understand and without impact in any other application or system.

  --------------------------
  [Original Description]

  A /etc/init.d/corosync-notifyd contains two definitions for the PIDFILE:
  > PIDFILE=/var/run/$NAME.pid
  > SCRIPTNAME=/etc/init.d/$NAME
  > PIDFILE=/var/run/corosync.pid

  The first one is correct and the second one is wrong as it refers to
  the corosync service's pidfile instead

  The corosync package version is 2.3.3-1ubuntu1

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/corosync/+bug/1437359/+subscriptions