← Back to team overview

group.of.nepali.translators team mailing list archive

[Bug 2006138] Re: non-root status has a bunch of warnings which should be avoided

 

This bug was fixed in the package ubuntu-advantage-tools - 27.14.4~18.04

---------------
ubuntu-advantage-tools (27.14.4~18.04) bionic; urgency=medium

  * Backport new upstream release: (LP: #2011477) to bionic

ubuntu-advantage-tools (27.14.4) lunar; urgency=medium

  * timer: disable update_contract_info job (LP: #2015302)
  * livepatch: prevent livepatch from auto-enabling and subsequently failing
    on non-amd64 systems (LP: #2015241)

ubuntu-advantage-tools (27.14.3) lunar; urgency=medium

  * livepatch: prevent livepatch from auto-enabling and subsequently failing
    on interim releases (LP: #2013409)

ubuntu-advantage-tools (27.14.2~23.04.1) lunar; urgency=medium

  * status:
    - always use dpkg instead of lscpu for fetching architecture
      information (LP: #2012735)

ubuntu-advantage-tools (27.14.1~23.04.1) lunar; urgency=medium

  * New upstream release 27.14.1
    - apt: fix a configuration leak in the apt.get_pkg_candidate_version
      function (LP: #2012642)

ubuntu-advantage-tools (27.14~23.04.1) lunar; urgency=medium

  * d/ubuntu-advantage-tools.{postinst,postrm,preinst}:
    - migrate certain settings out of uaclient.conf to a new file managed by
      the pro config subcommand (LP: #2004280)
  * d/ubuntu-advantage-tools.postinst:
    - refactor PREVIOUS_PKG_VER as a global variable
    - simplify how we add notices
  * New upstream release 27.14 (LP: #2011477)
    - api: new u.unattended_upgrades.status.v1 endpoint for querying status of
      unattended upgrades
    - apt:
      + remove legacy apt-hook
      + deliver json apt-hook for interim releases
      + fix cloud identification logic in json apt-hook
      + make all calls to esm-cache isolated from system configuration
        (LP: #2008280)
      + only set up the esm cache on supported systems (LP: #2004018)
    - fix:
      + format the output to be more readable (LP: #1926182)
      + add option to attach during a fix without a token
      + verify if fixed version can be installed before trying (LP: #2006705)
    - livepatch: show warning if current kernel is not supported
    - locks: alert user about corrupted lock files (LP: #1996931)
    - logging: logs are now formatted as jsonlines
    - motd: remove esm-apps announcement
    - notices: new representation on disk as separate files (LP: #1987738)
    - realtime: remove ubuntu-realtime package on disablement
    - status:
      + removed contract info update check network call
      + no longer includes warnings about notices when non-root (LP: #2006138)
      + unattached status sends virt type to contract server for better
        resource availability calculation
    - timer jobs: add daily job to check for contract updates
    - yaml: always import distro-provided pyyaml (LP: #2007234, LP: #2007241)

 -- Renan Rodrigo <renanrodrigo@xxxxxxxxxxxxx>  Thu, 06 Apr 2023
10:49:20 -0300

** Changed in: ubuntu-advantage-tools (Ubuntu Bionic)
       Status: Fix Committed => Fix Released

** Changed in: ubuntu-advantage-tools (Ubuntu Focal)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/2006138

Title:
  non-root status has a bunch of warnings which should be avoided

Status in ubuntu-advantage-tools package in Ubuntu:
  Fix Released
Status in ubuntu-advantage-tools source package in Xenial:
  Fix Released
Status in ubuntu-advantage-tools source package in Bionic:
  Fix Released
Status in ubuntu-advantage-tools source package in Focal:
  Fix Released
Status in ubuntu-advantage-tools source package in Jammy:
  Fix Released
Status in ubuntu-advantage-tools source package in Kinetic:
  Fix Released

Bug description:
  [Impact]
  When running `pro status --warning` as a non-root user, `pro` would show numerous unnecessary warnings.

  There were two warnings that showed up:
  1. a failed contract-server request warning
  2. a failure to remove a notice

  (1) is fixed because of a separate refactor that removed that network call from `pro status` entirely.
  (2) is fixed by removing the warning from the output. There is no reason the user needs to worry about these, and there's nothing for the user to do, so we shouldn't display them.

  [Test Case]
  On an attached machine, run `pro status --format json | jq .warnings`

  Before the fix, this will show many warnings.

  After the fix, this will be an empty list.

  [Regression Potential]
  The fix involved some refactors to the python code that adds and removes notices. If we made a mistake, then there could arise a situation where notices are not removed/added when they should be.

  [Discussion]
  These warnings about removing notices are due to us calling `notice.remove` in many places even when the notice is not present (the `remove` function is idempotent). The notices are stored in root-readable files becuase they can only be added when running root-only pro operations - that is why the non-root process cannot remove them. The case where a notice is present and should be removed will be resolved the next time that root runs `pro status`.

  [Original Description]

  $ sudo pro status --format=json | jq  | less

  ...
    "warnings": []

  But

  $ pro status --format=json | jq  | less

    "warnings": [
      {
        "message": "Failed to check for change in machine contract. Reason: Unauthorized: [https://contracts.canonical.com/v1/contracts/<xxxxx>?architecture=amd64&kernel=5.15.0-56-generic&series=jammy], unauthorized",
        "message_code": null,
        "service": null,
        "type": "system"
      },
      {
        "message": "Trying to remove notice as non-root user",
        "message_code": null,
        "service": null,
        "type": "system"
      },
      {
        "message": "Trying to remove notice as non-root user",
        "message_code": null,
        "service": null,
        "type": "system"
      },
  many of them

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2006138/+subscriptions