group.of.nepali.translators team mailing list archive

[Launchpad Bug Tracker <1896638@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package hibagent - 1.0.1-0ubuntu1.20.04.1

---------------
hibagent (1.0.1-0ubuntu1.20.04.1) focal; urgency=medium

  * d/p/lp1896638-set-resume-device-by-partition-uuid: Set resume device
    by PARTUUID instead of by name. Thanks to Tony Nie <zirann@xxxxxxxxxx>.
    (LP: #1896638)
  * d/p/lp2013336-do-not-modify-GRUB-config-on-GRUB2-systems: Do not attempt to
    modify non existent GRUB config file. Thanks to Robert Schweikert
    <rjschwei@xxxxxxxx>. (LP: #2013336)

 -- Alberto Contreras <alberto.contreras@xxxxxxxxxxxxx>  Tue, 04 Apr
2023 18:31:39 +0200

** Changed in: hibagent (Ubuntu Jammy)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1896638

Title:
  Path to swapfile doesn't use a static device path

Status in ec2-hibinit-agent package in Ubuntu:
  Fix Released
Status in hibagent package in Ubuntu:
  Fix Released
Status in ec2-hibinit-agent source package in Xenial:
  Fix Released
Status in hibagent source package in Xenial:
  Won't Fix
Status in ec2-hibinit-agent source package in Bionic:
  Fix Released
Status in hibagent source package in Bionic:
  Fix Released
Status in ec2-hibinit-agent source package in Focal:
  Fix Released
Status in hibagent source package in Focal:
  Fix Released
Status in ec2-hibinit-agent source package in Groovy:
  Fix Released
Status in hibagent source package in Groovy:
  Won't Fix
Status in hibagent source package in Jammy:
  Fix Released
Status in hibagent source package in Kinetic:
  Fix Released

Bug description:
  [Impact]

  * Using the device name on the kernel cmdline in the resume= option
  leads to failure to resume from hibernation when the device name is
  not stable, which can be the case for nvme drives.

  [Test Case]

  * ec2-hibinit-agent

    * Set up an EC2 instance to allow hibernation
    * Wait for hibinit-agent.service fully started
    * /etc/default/grub.d/99-set-swap.cfg should refer to the resume=partition by PARTUUID

  * hibagent

    * Spin up an EC2 spot instance with `hibernate` as `Interruption behavior` [1].
    * Install the latest hibagent: `sudo apt-get install hibagent`
    * Enable hibernation: `sudo /usr/bin/enable-ec2-spot-hibernation`
    * Create an AWS FIS experiment template to send a spot-instance-interruption signal [2], make it point to the created instance and launch it.
      Note: This step is optional, one can wait for AWS EC2 to send the interruption signal, but it could take a lot of time.
    * After some minutes, EC2 will send a signal to resume the interrupted instance.
    * Verify the instance has correctly been resumed from hibernation.

  [1] https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/interruption-behavior.html#specifying-spot-interruption-behavior
  [2] https://catalog.us-east-1.prod.workshops.aws/workshops/5fc0039f-9f15-47f8-aff0-09dc7b1779ee/en-US/030-basic-content/078-ec2-spot/020-spot-ec2-interrup

  [Regression Potential]

  * Failure to discover PARTUUID makes the system unable to resume. A
  potential crash would cause the system unable to set up hibernation or
  unable to resume. (On Focal PARTUUID is already in use, even without
  this fix.)

  [Original Bug Text]

  When the agent inserts the resume device path and offset into the
  kernel cmdline, it uses device names such as the following:

  `resume_offset=223232 resume=/dev/nvme1n1p1`

  The issue is that `/dev/nvme1n1p1` is not static. On the reboot, the
  block device may appear at `/dev/nvme0n1p1` resulting in failure to
  find the swapfile used to suspend.

  The solution should be to use a persistent block device naming scheme.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions