group.of.nepali.translators team mailing list archive
-
group.of.nepali.translators team
-
Mailing list archive
-
Message #48334
[Bug 1800499] Re: walinuxagent unit tests failing on build
Ah, I see there is an upload for noble in unapproved.
... but it doesn't mention this bug. Sorry, I'm confused. The upload in jammy unapproved also doesn't mention this bug. Was this uploaded?
NEVER MIND, I see it now in jammy unapproved :)
** Also affects: walinuxagent (Ubuntu Noble)
Importance: Undecided
Status: New
** Changed in: walinuxagent (Ubuntu Noble)
Status: New => In Progress
--
You received this bug notification because you are a member of नेपाली
भाषा समायोजकहरुको समूह, which is subscribed to Xenial.
Matching subscriptions: Ubuntu 16.04 Bugs
https://bugs.launchpad.net/bugs/1800499
Title:
walinuxagent unit tests failing on build
Status in walinuxagent package in Ubuntu:
Confirmed
Status in walinuxagent source package in Trusty:
Confirmed
Status in walinuxagent source package in Xenial:
Confirmed
Status in walinuxagent source package in Bionic:
Confirmed
Status in walinuxagent source package in Focal:
In Progress
Status in walinuxagent source package in Jammy:
In Progress
Bug description:
[ Impact ]
Nowadays, we do not run tests at building time (nor autopkgtest), relying only on upstream's effectiveness.
Actually, upstream has fixed some issues we had when running their test in Ubuntu, even adapting it to pytest from nose depending on the python version (nose for <= 3.9, pytest for >= 3.10), so our future buildings could be more robust using them.
[ Test Plan ]
You cannot see any test suite launched at building time in the recent logs. Instead of that, we got (e.g., Focal [2], line 1147):
# No test were run on any of the previous versions, temporarily
# ignoring the failures as they're not regressions (LP: #1800499)
# XXX: Those need to be fixed ASAP.
#-timeout 120 dh_auto_test -O--buildsystem=pybuild
After applying this fix, you can see the test running (e.g. Focal
[3], line 1317)
[ Where problems could occur ]
The main issue could be that the build could not end due to an error arising when running the tests. This situation can occur when running any test suite, and we check that this doesn't happen before the package's submission.
Some tests could fail in the future due to other factors (like new uses/behaviours in Python versions), but this is not the case on a LTS: If new tests are incorporated due to a new MRE process, they will be adapted to the python version present in every series.
[ Other Info ]
For every series, the changes that make this fix possible are (as
listed in the changelog):
- Jammy:
* Using now pytest for running the test suite (LP: #1800499) (LP: #2063046) as recommended by upstream:
- Focal:
* Upstream uses nose as testsuite under Python 3.9 (#3081)(LP: #1800499):
- Bionic, Xenial, Trusty: In progress
[2] https://launchpadlibrarian.net/601725982/buildlog_ubuntu-focal-amd64.walinuxagent_2.2.46-0ubuntu1.2_BUILDING.txt.gz
[3] https://launchpadlibrarian.net/753297945/buildlog_ubuntu-focal-amd64.walinuxagent_2.11.1.4-0ubuntu1~20.04.1+ppa2_BUILDING.txt.gz
[Original Description]
----------------------------------------------------------------
The new upstream version of walinuxagent (2.2.32, unreleased in Ubuntu
yet) and the previous 2.2.20 have failing unit-tests when run on
Ubuntu. None of the previous walinuxagent package versions in Ubuntu
were running the tests due to a bug in setup.py, resolved in a recent
upstream commit [1]. Now, with the fix applied, many tests can be seen
failing. All those unit-tests that are able to run during build should
be passing, otherwise having unit-tests makes no sense.
Example package build with listed unit-test failures:
https://launchpadlibrarian.net/395192988/buildlog_ubuntu-cosmic-
amd64.walinuxagent_2.2.32-0ubuntu1~test2_BUILDING.txt.gz
[1] https://github.com/Azure/WALinuxAgent/pull/1244
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/1800499/+subscriptions