← Back to team overview

gtg-contributors team mailing list archive

[Bug 491277] Re: PluginAPI : one EditorPluginApi for each Editor window

 

Marking as low, as so far no plugin writer complained for this (and it
can be easily managed inside a plugin, storing the task id)

** Changed in: gtg
    Milestone: 0.3 => 0.4

** Changed in: gtg
   Importance: High => Low

-- 
PluginAPI : one EditorPluginApi for each Editor window
https://bugs.launchpad.net/bugs/491277
You received this bug notification because you are a member of Gtg
contributors, which is subscribed to Getting Things GNOME!.

Status in Getting Things GNOME!: Confirmed

Bug description:
This is a refactorisation needed in the Plugin engine :

Somehow, there needs to be a way to store these task editor widgets while avoiding re-using them. Maybe the editor window part of plugins should be separated out into its own class that is instantiated once per editor window. That way, a plugin can maintain window-specific state (including widgets) that is kept separate from the global state. That might also clean up some of the messiness in the plugin API. Right now there are major differences in the PluginAPI object given to the plugin depending on whether the callback comes from the browser vs. an editor window. If the editor window part of the plugin is a separate class, it could be passed an EditorPluginAPI or something at creation, so the plugin wouldn't have to be passed a new PluginAPI at each callback.