gtg-contributors team mailing list archive

[Izidor Matušov <izidor.matusov@xxxxxxxxx>]

Hi everybody,

I spent the morning on Friday on a bus and did some cleanup. I have 
proposed two merge requests:

https://code.launchpad.net/~izidor/gtg/eval-cleanup/+merge/136021

Get rid of eval() from GTG's codebase. It might be potentionally harmful.

https://code.launchpad.net/~izidor/gtg/pep8/+merge/136022

PEP8-ification of GTG/core folder and couple of small cleanup like style 
comments, changing double underscope naming into a signal underscope 
naming for private variables.

Can you review them?

I have two questions:

1) What is the proper name of our GTG? Getting Things GNOME or Gettings 
Things GNOME? Some of our header files have the variant with -s

2) Bertrand> Why does your code include many testing in the pattern

if date == Date.no_date() or (date != Date.no_date() and date.is_fuzzy()):

According the current implementation of our Date class, no_date is a 
fuzzy date and thus the condition equals to

if date.is_fuzzy():

Is there any special reason for that?

Izidor