← Back to team overview

gtg team mailing list archive

[Bug 345504] Re: Removing a task should remove its sub-tasks

 

I have been hacking at it, and it seems that a simple change in
task.py's delete function would fix this. Instead of calling

task.remove_parent(self.get_id()) (line 483 I think)

for each subtask, my change calls

self.req.delete_task(task.get_id())

which seems to do the trick. From what I can read from the code this is
not a breach of the architecture, though I might be wrong. The net
result is that all subtasks (as well as their subtask and so on) to the
deleted task are deleted.

So if we had 
1.
A
 - B
  - C
  - D
 - E
  - F

Then deleting E would leave us with
2.
A
 - B
  - C
  - D

And if we deleted A (in either 1 or 2) there would be no tasks left.
Unless there are any objections I would like to test it a bit more, and then try to push it to a branch.

-- 
Removing a task should remove its sub-tasks
https://bugs.launchpad.net/bugs/345504
You received this bug notification because you are a member of Gtg
developers, which is subscribed to Getting Things GNOME!.

Status in Getting Things GNOME!: Confirmed

Bug description:
When I remove a task with sub-tasks, the sub-tasks are kept and replace the removed task. That's counter-intuitive. Sub-tasks should be removed together and the confirmation screen should warn that the X sub-tasks will also be removed.