← Back to team overview

gtg team mailing list archive

[Merge] lp:~gtg-user/gtg/statusicon-fix into lp:gtg

 

Luca Invernizzi has proposed merging lp:~gtg-user/gtg/statusicon-fix into lp:gtg.

    Requested reviews:
    Gtg developers (gtg)


fixes bug #434720 
-- 
https://code.launchpad.net/~gtg-user/gtg/statusicon-fix/+merge/14513
Your team Gtg developers is subscribed to branch lp:gtg.
=== modified file 'GTG/plugins/notification_area/notification_area.py'
--- GTG/plugins/notification_area/notification_area.py	2009-09-12 15:16:10 +0000
+++ GTG/plugins/notification_area/notification_area.py	2009-11-05 23:05:19 +0000
@@ -27,9 +27,11 @@
     def activate(self, plugin_api):
         data_dir = plugin_api.get_data_dir()
         icon = gtk.gdk.pixbuf_new_from_file_at_size(data_dir + "/icons/hicolor/16x16/apps/gtg.png", 16, 16)
-        statusicon = gtk.status_icon_new_from_pixbuf(icon)
-        statusicon.set_tooltip("Getting Things Gnome!")
-        statusicon.connect('activate', self.minimize, plugin_api)
+        if not hasattr(self,"statusicon"):
+            self.statusicon = gtk.status_icon_new_from_pixbuf(icon)
+            self.statusicon.set_tooltip("Getting Things Gnome!")
+            self.statusicon.connect('activate', self.minimize, plugin_api)
+        self.statusicon.set_visible(True)
         
         menu = gtk.Menu()
         
@@ -58,13 +60,13 @@
         menu.append(gtk.SeparatorMenuItem())
         
         menuItem = gtk.ImageMenuItem(gtk.STOCK_QUIT)
-        menuItem.connect('activate', self.exit, statusicon)
+        menuItem.connect('activate', self.exit, self.statusicon)
         menu.append(menuItem)
         
-        statusicon.connect('popup-menu', self.on_icon_popup, menu)
+        self.statusicon.connect('popup-menu', self.on_icon_popup, menu)
         
     def deactivate(self, plugin_api):
-        pass
+        self.statusicon.set_visible(False)
     
     def onTaskOpened(self, plugin_api):
         pass
@@ -100,4 +102,4 @@
         about.show_all()
     
     def exit(self, widget, data=None):
-        gtk.main_quit()
\ No newline at end of file
+        gtk.main_quit()


Follow ups