← Back to team overview

gtg team mailing list archive

[Merge] lp:~gtg-user/gtg/about_window_crash_fix into lp:gtg

 

Luca Invernizzi has proposed merging lp:~gtg-user/gtg/about_window_crash_fix into lp:gtg.

    Requested reviews:
    Gtg developers (gtg)


Fixes bug #476119 by handling the delete-event correctly
-- 
https://code.launchpad.net/~gtg-user/gtg/about_window_crash_fix/+merge/14527
Your team Gtg developers is subscribed to branch lp:gtg.
=== modified file 'GTG/taskbrowser/browser.py'
--- GTG/taskbrowser/browser.py	2009-11-05 22:59:23 +0000
+++ GTG/taskbrowser/browser.py	2009-11-06 05:20:23 +0000
@@ -328,6 +328,8 @@
                 self.on_toolbar_toggled,
             "on_about_clicked":
                 self.on_about_clicked,
+            "on_about_delete":
+                self.on_about_close,
             "on_about_close":
                 self.on_about_close,
             "on_nonworkviewtag_toggled":
@@ -1015,6 +1017,7 @@
 
     def on_about_close(self, widget, response):
         self.about.hide()
+        return True
 
     def on_colorchooser_activate(self, widget):
         #TODO: Color chooser should be refactorized in its own class. Well, in

=== modified file 'GTG/taskbrowser/taskbrowser.glade'
--- GTG/taskbrowser/taskbrowser.glade	2009-11-05 22:50:51 +0000
+++ GTG/taskbrowser/taskbrowser.glade	2009-11-06 05:20:23 +0000
@@ -891,6 +891,7 @@
     <property name="logo_icon_name">gtg</property>
     <property name="wrap_license">True</property>
     <signal name="response" handler="on_about_close"/>
+    <signal name="delete_event" handler="on_about_delete"/>
     <child internal-child="vbox">
       <widget class="GtkVBox" id="dialog-vbox2">
         <property name="visible">True</property>


Follow ups