gtg team mailing list archive

[Manuel de la Pena <manuel.delapena@xxxxxxxxxxxxx>]

Manuel de la Pena has proposed merging lp:~mandel/gtg/tomboy_reference_before_assignment into lp:gtg.

Requested reviews:
  Gtg developers (gtg)
Related bugs:
  #673745 tomboy referenced before assigment
  https://bugs.launchpad.net/bugs/673745


Fixes lp:673745 by ensuring that the var is init to be empty before the with block so that it can be use later.
-- 
https://code.launchpad.net/~mandel/gtg/tomboy_reference_before_assignment/+merge/40585
Your team Gtg developers is requested to review the proposed merge of lp:~mandel/gtg/tomboy_reference_before_assignment into lp:gtg.

=== modified file 'GTG/backends/generictomboy.py'
--- GTG/backends/generictomboy.py	2010-08-26 23:32:33 +0000
+++ GTG/backends/generictomboy.py	2010-11-10 22:22:40 +0000
@@ -97,6 +97,7 @@
         Gets all the notes from Tomboy and sees if they must be added in GTG
         (and, if so, it adds them).
         '''
+        tomboy_notes = []
         with self.TomboyConnection(self, *self.BUS_ADDRESS) as tomboy:
             with self.DbusWatchdog(self):
                 tomboy_notes = [note_id for note_id in \